From: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org> To: Goldwyn Rodrigues <rgoldwyn-l3A5Bk7waGM@public.gmane.org> Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jack-IBi9RG/b67k@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org, avi-VrcmuVmyx1hWk0Htik3J/w@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Goldwyn Rodrigues <rgoldwyn-IBi9RG/b67k@public.gmane.org> Subject: Re: [PATCH 6/8] nowait aio: ext4 Date: Tue, 9 May 2017 16:57:54 +0200 [thread overview] Message-ID: <20170509145754.GG21467@quack2.suse.cz> (raw) In-Reply-To: <20170509122219.31756-7-rgoldwyn-l3A5Bk7waGM@public.gmane.org> On Tue 09-05-17 07:22:17, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues <rgoldwyn-IBi9RG/b67k@public.gmane.org> > > Return EAGAIN if any of the following checks fail for direct I/O: > + i_rwsem is lockable > + Writing beyond end of file (will trigger allocation) > + Blocks are not allocated at the write location > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn-IBi9RG/b67k@public.gmane.org> The patch looks good. You can add: Reviewed-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org> Honza > --- > fs/ext4/file.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index cefa9835f275..2efdc6d4d3e8 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -216,7 +216,13 @@ ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > return ext4_dax_write_iter(iocb, from); > #endif > > - inode_lock(inode); > + if (iocb->ki_flags & IOCB_NOWAIT) { > + if (!inode_trylock(inode)) > + return -EAGAIN; > + } else { > + inode_lock(inode); > + } > + > ret = ext4_write_checks(iocb, from); > if (ret <= 0) > goto out; > @@ -235,9 +241,15 @@ ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > > iocb->private = &overwrite; > /* Check whether we do a DIO overwrite or not */ > - if (o_direct && ext4_should_dioread_nolock(inode) && !unaligned_aio && > - ext4_overwrite_io(inode, iocb->ki_pos, iov_iter_count(from))) > - overwrite = 1; > + if (o_direct && !unaligned_aio) { > + if (ext4_overwrite_io(inode, iocb->ki_pos, iov_iter_count(from))) { > + if (ext4_should_dioread_nolock(inode)) > + overwrite = 1; > + } else if (iocb->ki_flags & IOCB_NOWAIT) { > + ret = -EAGAIN; > + goto out; > + } > + } > > ret = __generic_file_write_iter(iocb, from); > inode_unlock(inode); > -- > 2.12.0 > -- Jan Kara <jack-IBi9RG/b67k@public.gmane.org> SUSE Labs, CR
next prev parent reply other threads:[~2017-05-09 14:57 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-09 12:22 [PATCH 0/8 v7] No wait AIO Goldwyn Rodrigues 2017-05-09 12:22 ` [PATCH 1/8] Use RWF_* flags for AIO operations Goldwyn Rodrigues 2017-05-11 7:40 ` Christoph Hellwig 2017-05-09 12:22 ` [PATCH 2/8] nowait aio: Introduce RWF_NOWAIT Goldwyn Rodrigues 2017-05-11 7:42 ` Christoph Hellwig 2017-05-09 12:22 ` [PATCH 3/8] nowait aio: return if direct write will trigger writeback Goldwyn Rodrigues 2017-05-11 7:42 ` Christoph Hellwig 2017-05-09 12:22 ` [PATCH 4/8] nowait-aio: Introduce IOMAP_NOWAIT Goldwyn Rodrigues 2017-05-09 12:22 ` [PATCH 5/8] nowait aio: return on congested block device Goldwyn Rodrigues 2017-05-11 7:44 ` Christoph Hellwig [not found] ` <20170511074451.GD15626-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 2017-05-11 18:16 ` Goldwyn Rodrigues 2017-05-09 12:22 ` [PATCH 6/8] nowait aio: ext4 Goldwyn Rodrigues [not found] ` <20170509122219.31756-7-rgoldwyn-l3A5Bk7waGM@public.gmane.org> 2017-05-09 14:57 ` Jan Kara [this message] 2017-05-09 12:22 ` [PATCH 7/8] nowait aio: xfs Goldwyn Rodrigues 2017-05-11 7:45 ` Christoph Hellwig 2017-05-09 12:22 ` [PATCH 8/8] nowait aio: btrfs Goldwyn Rodrigues -- strict thread matches above, loose matches on Subject: below -- 2017-04-14 12:02 [PATCH 0/8 v6] No wait AIO Goldwyn Rodrigues 2017-04-14 12:02 ` [PATCH 6/8] nowait aio: ext4 Goldwyn Rodrigues 2017-04-03 18:52 [PATCH 0/8 v4] No wait AIO Goldwyn Rodrigues 2017-04-03 18:53 ` [PATCH 6/8] nowait aio: ext4 Goldwyn Rodrigues 2017-04-04 7:58 ` Jan Kara 2017-04-04 8:41 ` Christoph Hellwig 2017-04-04 18:41 ` Goldwyn Rodrigues 2017-04-10 7:45 ` Christoph Hellwig [not found] ` <20170410074539.GA18250-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 2017-04-10 12:37 ` Jan Kara 2017-04-10 14:39 ` Christoph Hellwig 2017-04-10 15:13 ` Jan Kara 2017-03-15 21:50 [PATCH 0/8 v3] No wait AIO Goldwyn Rodrigues 2017-03-15 21:51 ` [PATCH 6/8] nowait aio: ext4 Goldwyn Rodrigues
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170509145754.GG21467@quack2.suse.cz \ --to=jack-alswssmvlrq@public.gmane.org \ --cc=avi-VrcmuVmyx1hWk0Htik3J/w@public.gmane.org \ --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \ --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \ --cc=jack-IBi9RG/b67k@public.gmane.org \ --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=rgoldwyn-IBi9RG/b67k@public.gmane.org \ --cc=rgoldwyn-l3A5Bk7waGM@public.gmane.org \ --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \ --cc=tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \ --subject='Re: [PATCH 6/8] nowait aio: ext4' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).