Re: [PATCH 03/20] asm-generic: Drop getrlimit and setrlimit syscalls from default list

From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-doc@vger.kernel.org, szabolcs.nagy@arm.com,
	Catalin Marinas <catalin.marinas@arm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	David Howells <dhowells@redhat.com>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	Yury Norov <ynorov@caviumnetworks.com>,
	linux@lists.openrisc.net, linux-hexagon@vger.kernel.org,
	Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
	Joseph Myers <joseph@codesourcery.com>,
	linux-arch <linux-arch@vger.kernel.org>,
	Chen Liqin <liqin.linux@gmail.com>,
	zhouchengming1@huawei.com, Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Steve Ellcey <sellcey@caviumnetworks.com>,
	linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>,
	Andreas Schwab <schwab@suse.de>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	Alexander Graf <agraf@suse.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Lennox Wu <lennox.wu@gm>
Subject: Re: [PATCH 03/20] asm-generic: Drop getrlimit and setrlimit syscalls from default list
Date: Mon, 19 Jun 2017 23:10:23 +0100	[thread overview]
Message-ID: <20170619221023.GT6973@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <CAK8P3a0M2TkoUY4KBgmtnh3NDNj-oSNOpVagHVFuFBEYnAYp8Q@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1857 bytes --]

On Mon, Jun 19, 2017 at 11:58:41PM +0200, Arnd Bergmann wrote:
> On Mon, Jun 19, 2017 at 11:42 PM, James Hogan <james.hogan@imgtec.com> wrote:
> > On Mon, Jun 19, 2017 at 06:49:46PM +0300, Yury Norov wrote:
> > Subject: [PATCH] Deprecate stat syscalls superseded by statx
> >
> > Various stat system calls can now be implemented as userland wrappers
> > around the new statx system call, so allow them to be removed from the
> > kernel by default for new architectures / ABIs.
> >
> > This involves adding __ARCH_WANT_SYSCALL_UNXSTAT to each existing
> > architecture, which enables the relevant stat system calls in the
> > generic system call list (if used). It also conditionally defines the
> > syscalls in fs/stat.c and struct stat / struct stat64 in
> > asm-generic/stat.h.
> >
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: linux-fsdevel@vger.kernel.org
> > Cc: linux-arch@vger.kernel.org
> > Cc: linux-api@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> 
> Good idea:
> 
> Acked-by:  Arnd Bergmann <arnd@arndb.de>

Thanks,

> 
> > +/* statx deprecates the un-extended stat syscalls which use struct stat[64] */
> > +#ifdef __ARCH_WANT_SYSCALL_UNXSTAT
> 
> I'm glad you explain what 'UNXSTAT' means here, since I would not
> have otherwise guessed it, but I also can't think of anything more
> intuitive.

Yeh, I renamed that several times while playing around with this :-).

The stat syscalls remind me a bit of the Vicar of Dibley episode where
the new road named "New Road" necessitates the renaming of the existing
"New Road" to "Quite Old Road" and "Quite Old Road" to "Really Quite Old
Road" and "Old Road" to "Very Old Road"!

Cheers
James

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc