From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
mfuzzey@parkeon.com, ebiederm@xmission.com,
dmitry.torokhov@gmail.com, wagi@monom.org, dwmw2@infradead.org,
jewalt@lgsinnovations.com, rafal@milecki.pl,
arend.vanspriel@broadcom.com, rjw@rjwysocki.net,
yi1.li@linux.intel.com, atull@kernel.org,
moritz.fischer@ettus.com, pmladek@suse.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
luciano.coelho@intel.com, kvalo@codeaurora.org, luto@kernel.org,
torvalds@linux-foundation.org, keescook@chromium.org,
takahiro.akashi@linaro.org, dhowells@redhat.com,
pjones@redhat.com, hdegoede@redhat.com, alan@linux.intel.com,
tytso@mit.edu, mtk.manpages@gmail.com,
paul.gortmaker@windriver.com, mtosatti@redhat.com,
mawilcox@microsoft.com, linux-api@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] swait: add the missing killable swaits
Date: Thu, 29 Jun 2017 15:35:30 +0200 [thread overview]
Message-ID: <20170629133530.GA14747@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1706291504570.1861@nanos>
On Thu, Jun 29, 2017 at 03:05:26PM +0200, Thomas Gleixner wrote:
> On Thu, 29 Jun 2017, Greg KH wrote:
> > On Wed, Jun 14, 2017 at 03:20:15PM -0700, Luis R. Rodriguez wrote:
> > Do you really still want to add these, now that we know we shouldn't be
> > using swait in "real" code? :)
>
> And who defined that it should not be used in real code?
Linus did, in a different firmware thread. You have to _really_ know
what you are doing to use this interface, and the firmware interface
shouldn't be using it. So adding new apis just for firmware does not
seem like a wise decision at this point in time.
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-29 13:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 22:20 [PATCH 0/4] firmware: fix fallback mechanism by ignoring SIGCHLD Luis R. Rodriguez
2017-06-14 22:20 ` [PATCH 1/4] test_firmware: add test case for SIGCHLD on sync fallback Luis R. Rodriguez
2017-06-14 22:20 ` [PATCH 2/4] swait: add the missing killable swaits Luis R. Rodriguez
[not found] ` <20170614222017.14653-3-mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-29 12:54 ` Greg KH
[not found] ` <20170629125402.GH26046-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-06-29 13:05 ` Thomas Gleixner
2017-06-29 13:35 ` Greg KH [this message]
2017-06-29 13:46 ` Thomas Gleixner
2017-06-29 16:13 ` Linus Torvalds
2017-06-29 16:31 ` Matthew Wilcox
2017-06-29 17:29 ` Luis R. Rodriguez
2017-06-29 17:40 ` Davidlohr Bueso
2017-06-29 17:57 ` Linus Torvalds
2017-06-29 18:33 ` Davidlohr Bueso
[not found] ` <20170629183339.GD3954-3dK4OQgjB4rH06JGZaSw0A@public.gmane.org>
2017-06-29 18:59 ` Linus Torvalds
[not found] ` <CA+55aFz8Mhx+A-g-5yOG-O1ZLRUR_fpeeA4iBNGH8EnDBZEdpA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-29 19:40 ` Luis R. Rodriguez
2017-06-29 19:44 ` Luis R. Rodriguez
[not found] ` <20170629194455.GR21846-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-06-29 20:58 ` Jakub Kicinski
2017-06-29 22:50 ` Luis R. Rodriguez
2017-06-29 22:53 ` Jakub Kicinski
2017-06-29 23:00 ` Luis R. Rodriguez
2017-06-29 23:06 ` Jakub Kicinski
[not found] ` <20170629225003.GU21846-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-07-12 21:33 ` Luis R. Rodriguez
[not found] ` <20170629194015.GQ21846-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-06-29 20:57 ` Linus Torvalds
2017-07-05 2:06 ` Davidlohr Bueso
[not found] ` <20170705020635.GD11168-3dK4OQgjB4rH06JGZaSw0A@public.gmane.org>
2017-07-07 19:58 ` Linus Torvalds
2017-07-07 22:27 ` Davidlohr Bueso
2017-07-07 22:48 ` Linus Torvalds
2017-06-29 19:15 ` Marcelo Tosatti
[not found] ` <20170629191506.GB12368-I4X2Mt4zSy4@public.gmane.org>
2017-06-30 4:03 ` Linus Torvalds
2017-06-30 11:55 ` Marcelo Tosatti
2017-06-30 11:57 ` Marcelo Tosatti
2017-06-30 17:30 ` Krister Johansen
2017-06-14 22:20 ` [PATCH 3/4] firmware: avoid invalid fallback aborts by using killable swait Luis R. Rodriguez
2017-06-14 22:20 ` [PATCH 4/4] firmware: send -EINTR on signal abort on fallback mechanism Luis R. Rodriguez
2017-06-15 7:49 ` [PATCH 0/4] firmware: fix fallback mechanism by ignoring SIGCHLD Martin Fuzzey
[not found] ` <20170614222017.14653-1-mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-26 21:19 ` Luis R. Rodriguez
2017-06-29 15:14 ` Greg KH
[not found] ` <20170629151442.GA4880-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-06-29 17:29 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629133530.GA14747@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=emmanuel.grumbach@intel.com \
--cc=hdegoede@redhat.com \
--cc=jewalt@lgsinnovations.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mcgrof@kernel.org \
--cc=mfuzzey@parkeon.com \
--cc=moritz.fischer@ettus.com \
--cc=mtk.manpages@gmail.com \
--cc=mtosatti@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rafal@milecki.pl \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).