On Wed, Aug 09, 2017 at 09:52:41AM -0600, Jason Gunthorpe wrote: > On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > > userspace users of this file, 'sockaddr_in' needs to come from glibc's > > > 'netinet/in.h' instead.. > > > Is it wrong to include include/uapi/linux/in.h from userspace? > > Generally speaking userspace should always use the glibc version of > the headers and not headers from under linux/ Sorry? Isn't the main idea of UAPI in providing the Linux interface for userspace, unlike glibc headers that provide other more or less standard interfaces like GNU, POSIX, etc? -- ldv