From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net-next v7 01/10] selftest: Enhance kselftest_harness.h with a step mechanism Date: Wed, 23 Aug 2017 19:31:07 -0700 Message-ID: <20170824023105.gt6lyn2snhczryik@ast-mbp> References: <20170821000933.13024-1-mic@digikod.net> <20170821000933.13024-2-mic@digikod.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <20170821000933.13024-2-mic@digikod.net> To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Lutomirski , Arnaldo Carvalho de Melo , Casey Schaufler , Daniel Borkmann , David Drysdale , "David S . Miller" , "Eric W . Biederman" , James Morris , Jann Horn , Jonathan Corbet , Matthew Garrett , Michael Kerrisk , Kees Cook , Paul Moore , Sargun Dhillon , "Serge E . Hallyn" , Shuah Khan , Tejun Heo , Thomas Graf , Will Drewry , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-sec List-Id: linux-api@vger.kernel.org On Mon, Aug 21, 2017 at 02:09:24AM +0200, Mickaël Salaün wrote: > This step mechanism may be useful to return an information about the > error without being able to write to TH_LOG_STREAM. > > Set _metadata->no_print to true to print this counter. > > Signed-off-by: Mickaël Salaün > Cc: Andy Lutomirski > Cc: Arnaldo Carvalho de Melo > Cc: Kees Cook > Cc: Shuah Khan > Cc: Will Drewry > Link: https://lkml.kernel.org/r/CAGXu5j+D-FP8Kt9unNOqKrQJP4DYTpmgkJxWykZyrYiVPz3Y3Q@mail.gmail.com > --- > > This patch is intended to the kselftest tree: > https://lkml.kernel.org/r/20170806232337.4191-1-mic@digikod.net > > Changes since v6: > * add the step counter in assert/expect macros and use _metadata to > enable the counter (suggested by Kees Cook) > --- > tools/testing/selftests/kselftest_harness.h | 31 ++++++++++++++++++++++----- > tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- > 2 files changed, 27 insertions(+), 6 deletions(-) is there a dependency on this in patches 2+ ? if not, I would send this patch to selftests right away.