From: Michal Hocko <mhocko@kernel.org>
To: William Kucharski <william.kucharski@oracle.com>
Cc: linux-api@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc
Date: Tue, 27 Nov 2018 17:25:44 +0100 [thread overview]
Message-ID: <20181127162544.GA6923@dhcp22.suse.cz> (raw)
In-Reply-To: <04647F77-FE93-4A8E-90C1-4245709B88A5@oracle.com>
On Tue 27-11-18 07:50:08, William Kucharski wrote:
>
>
> > On Nov 27, 2018, at 6:17 AM, Michal Hocko <mhocko@kernel.org> wrote:
> >
> > This is only about the process wide flag to disable THP. I do not see
> > how this can be alighnement related. I suspect you wanted to ask in the
> > smaps patch?
>
> No, answered below.
>
> >
> >> I'm having to deal with both these issues in the text page THP
> >> prototype I've been working on for some time now.
> >
> > Could you be more specific about the issue and how the alignment comes
> > into the game? The only thing I can think of is to not report VMAs
> > smaller than the THP as eligible. Is this what you are looking for?
>
> Basically, if the faulting VA is one that cannot be mapped with a THP
> due to alignment or size constraints, it may be "eligible" for THP
> mapping but ultimately can't be.
>
> I was just double checking that this was meant to be more of a check done
> before code elsewhere performs additional checks and does the actual THP
> mapping, not an all-encompassing go/no go check for THP mapping.
I am still not sure I follow you completely here. This just reports
per-task eligibility. The system wide eligibility is reported via sysfs
and the per vma eligibility is reported via /proc/<pid>/smaps.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-11-27 16:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 10:35 [RFC PATCH 0/3] THP eligibility reporting via proc Michal Hocko
2018-11-20 10:35 ` [RFC PATCH 1/3] mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps Michal Hocko
2018-11-20 10:51 ` Jan Kara
2018-11-20 11:41 ` Michal Hocko
2018-11-21 0:01 ` David Rientjes
2018-11-21 6:56 ` Michal Hocko
2018-11-20 18:32 ` Dan Williams
2018-11-21 7:05 ` Michal Hocko
2018-11-21 18:01 ` Mike Rapoport
2018-11-21 17:54 ` Mike Rapoport
2018-11-21 17:58 ` Michal Hocko
2018-11-23 13:47 ` Vlastimil Babka
2018-11-20 10:35 ` [RFC PATCH 2/3] mm, thp, proc: report THP eligibility for each vma Michal Hocko
2018-11-20 11:42 ` Michal Hocko
2018-11-23 15:07 ` Vlastimil Babka
2018-11-23 15:21 ` Michal Hocko
2018-11-23 15:24 ` Vlastimil Babka
2018-11-20 10:35 ` [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc Michal Hocko
2018-11-20 11:42 ` Michal Hocko
2018-11-23 15:49 ` Vlastimil Babka
2018-11-27 0:33 ` William Kucharski
2018-11-27 13:17 ` Michal Hocko
2018-11-27 14:50 ` William Kucharski
2018-11-27 16:25 ` Michal Hocko [this message]
2018-11-27 16:50 ` Vlastimil Babka
2018-11-27 17:06 ` William Kucharski
2018-12-07 10:55 ` [RFC PATCH 0/3] THP eligibility reporting via proc Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127162544.GA6923@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).