From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenz Bauer Subject: [PATCH v4 0/4] Fix unsafe BPF_PROG_TEST_RUN interface Date: Wed, 28 Nov 2018 16:53:08 +0000 Message-ID: <20181128165312.19500-1-lmb@cloudflare.com> References: <20181116125329.3974-1-lmb@cloudflare.com> Return-path: In-Reply-To: <20181116125329.3974-1-lmb@cloudflare.com> Sender: netdev-owner@vger.kernel.org To: ast@kernel.org, daniel@iogearbox.net Cc: netdev@vger.kernel.org, linux-api@vger.kernel.org, ys114321@gmail.com, Lorenz Bauer List-Id: linux-api@vger.kernel.org Right now, there is no safe way to use BPF_PROG_TEST_RUN with data_out. This is because bpf_test_finish copies the output buffer to user space without checking its size. This can lead to the kernel overwriting data in user space after the buffer if xdp_adjust_head and friends are in play. Changes in v4: * Document bpf_prog_test_run and bpf_prog_test_run_xattr * Use struct bpf_prog_test_run_attr for return values Changes in v3: * Introduce bpf_prog_test_run_xattr instead of modifying the existing function Changes in v2: * Make the syscall return ENOSPC if data_size_out is too small * Make bpf_prog_test_run return EINVAL if size_out is missing * Document the new behaviour of data_size_out Lorenz Bauer (4): bpf: respect size hint to BPF_PROG_TEST_RUN if present tools: sync uapi/linux/bpf.h libbpf: add bpf_prog_test_run_xattr selftests: add a test for bpf_prog_test_run_xattr include/uapi/linux/bpf.h | 7 ++- net/bpf/test_run.c | 15 ++++++- tools/include/uapi/linux/bpf.h | 7 ++- tools/lib/bpf/bpf.c | 23 ++++++++++ tools/lib/bpf/bpf.h | 19 ++++++++ tools/testing/selftests/bpf/test_progs.c | 55 +++++++++++++++++++++++- 6 files changed, 119 insertions(+), 7 deletions(-) -- 2.17.1