From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aleksa Sarai Subject: Re: [PATCH RFC 0/1] mount: universally disallow mounting over symlinks Date: Thu, 16 Jan 2020 01:29:06 +1100 Message-ID: <20200115142906.saagd2lse7i7njux@yavin> References: <20200101144407.ugjwzk7zxrucaa6a@yavin.dot.cyphar.com> <20200101234009.GB8904@ZenIV.linux.org.uk> <20200102035920.dsycgxnb6ba2jhz2@yavin.dot.cyphar.com> <20200103014901.GC8904@ZenIV.linux.org.uk> <20200108031314.GE8904@ZenIV.linux.org.uk> <20200110210719.ktg3l2kwjrdutlh6@yavin> <20200114045733.GW8904@ZenIV.linux.org.uk> <20200114200150.ryld4npoblns2ybe@yavin> <20200115142517.GI8904@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jicj4wr2fyynqqnx" Return-path: Content-Disposition: inline In-Reply-To: <20200115142517.GI8904@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org To: Al Viro Cc: Linus Torvalds , David Howells , Eric Biederman , stable , Christian Brauner , Serge Hallyn , dev@opencontainers.org, Linux Containers , Linux API , linux-fsdevel , Linux Kernel Mailing List , Ian Kent List-Id: linux-api@vger.kernel.org --jicj4wr2fyynqqnx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2020-01-15, Al Viro wrote: > On Wed, Jan 15, 2020 at 07:01:50AM +1100, Aleksa Sarai wrote: >=20 > > Yes, there were two patches I sent a while ago[1]. I can re-send them if > > you like. The second patch switches open_how->mode to a u64, but I'm > > still on the fence about whether that makes sense to do... >=20 > IMO plain __u64 is better than games with __aligned_u64 - all sizes are > fixed, so... >=20 > > [1]: https://lore.kernel.org/lkml/20191219105533.12508-1-cyphar@cyphar.= com/ >=20 > Do you want that series folded into "open: introduce openat2(2) syscall" > and "selftests: add openat2(2) selftests" or would you rather have them > appended at the end of the series. Personally I'd go for "fold them in" > if it had been about my code, but it's really up to you. "fold them in" would probably be better to avoid making the mainline history confusing afterwards. Thanks. --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --jicj4wr2fyynqqnx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXh8hrwAKCRCdlLljIbnQ Eg7QAP91xggZVGKm7aFrAM05CS20D+mj/0AuHhgnu+nz3X+6qwD9FPEQyNWth7f6 RpocX3ojVl40GZTohTHSOJag04kTbAQ= =WA+D -----END PGP SIGNATURE----- --jicj4wr2fyynqqnx--