From: Michal Hocko <mhocko@kernel.org>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Vlastimil Babka <vbabka@suse.cz>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, Ivan Teterevkov <ivan.teterevkov@nutanix.com>,
David Rientjes <rientjes@google.com>,
Matthew Wilcox <willy@infradead.org>,
"Guilherme G . Piccoli" <gpiccoli@canonical.com>
Subject: Re: [RFC v2 1/2] kernel/sysctl: support setting sysctl parameters from kernel command line
Date: Thu, 26 Mar 2020 14:39:15 +0100 [thread overview]
Message-ID: <20200326133915.GQ27965@dhcp22.suse.cz> (raw)
In-Reply-To: <20200326133041.a3zit3gzdqmphane@wittgenstein>
On Thu 26-03-20 14:30:41, Christian Brauner wrote:
> On Thu, Mar 26, 2020 at 07:58:29AM +0100, Michal Hocko wrote:
> > On Wed 25-03-20 17:20:40, Eric W. Biederman wrote:
> > > Vlastimil Babka <vbabka@suse.cz> writes:
> > [...]
> > > > + if (strncmp(param, "sysctl.", sizeof("sysctl.") - 1))
> > > > + return 0;
> > >
> > > Is there any way we can use a slash separated path. I know
> > > in practice there are not any sysctl names that don't have
> > > a '.' in them but why should we artifically limit ourselves?
> >
> > Because this is the normal userspace interface? Why should it be any
> > different from calling sysctl?
> > [...]
>
> Imho, we should use ".". Kernel developers aren't the ones setting
> these options, admins are and if I think back to the times doing that as
> a job at uni I'd be very confused if I learned that I get to set sysctl
> options through the kernel command but need to use yet another format
> than what I usually do to set those from the shell. Consistency is most
> of the times to be preferred imho.
Absolutely agreed! Even if sysctl can consume / instead of ., which was a
news to me btw, the majority of the usage is with `.'
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-03-26 13:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 12:03 [RFC v2 1/2] kernel/sysctl: support setting sysctl parameters from kernel command line Vlastimil Babka
2020-03-25 12:03 ` [RFC v2 2/2] kernel/sysctl: support handling command line aliases Vlastimil Babka
2020-03-25 14:29 ` Michal Hocko
2020-03-25 14:36 ` Vlastimil Babka
2020-03-25 14:44 ` Michal Hocko
2020-03-25 22:42 ` Kees Cook
2020-03-29 15:00 ` Arvind Sankar
2020-03-25 21:21 ` [RFC v2 1/2] kernel/sysctl: support setting sysctl parameters from kernel command line Kees Cook
2020-03-26 9:30 ` Vlastimil Babka
2020-03-25 22:20 ` Eric W. Biederman
2020-03-25 22:54 ` Kees Cook
2020-03-26 6:58 ` Michal Hocko
2020-03-26 7:21 ` Kees Cook
2020-03-26 12:45 ` Eric W. Biederman
2020-03-30 22:09 ` Luis Chamberlain
2020-03-26 13:30 ` Christian Brauner
2020-03-26 13:39 ` Michal Hocko [this message]
2020-03-26 13:29 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326133915.GQ27965@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=gpiccoli@canonical.com \
--cc=ivan.teterevkov@nutanix.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).