From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C16C433E4 for ; Mon, 20 Jul 2020 18:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3C732070A for ; Mon, 20 Jul 2020 18:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730346AbgGTSLM (ORCPT ); Mon, 20 Jul 2020 14:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728448AbgGTSLM (ORCPT ); Mon, 20 Jul 2020 14:11:12 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61712C061794; Mon, 20 Jul 2020 11:11:12 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxaFn-00GiGn-Lp; Mon, 20 Jul 2020 18:11:07 +0000 Date: Mon, 20 Jul 2020 19:11:07 +0100 From: Al Viro To: Christoph Hellwig Cc: Linus Torvalds , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 05/24] fs: move the putname from filename_lookup to the callers Message-ID: <20200720181107.GQ2786714@ZenIV.linux.org.uk> References: <20200720155902.181712-1-hch@lst.de> <20200720155902.181712-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720155902.181712-6-hch@lst.de> Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Jul 20, 2020 at 05:58:43PM +0200, Christoph Hellwig wrote: > This allows reusing the struct filename for retries, and will also allow > pushing the getname up the stack for a few places to allower for better > handling of kernel space filenames. You are complicating the callers for no good reason. NAK. The same goes for the previous patch in the series. Keep the cleanup rules simple. Sure, I understand wanting to avoid special rules for early bootstrap, but that's a corner case; don't make fs/namei.c harder to follow.