From: Kees Cook <keescook@chromium.org>
To: Will Deacon <will@kernel.org>
Cc: Andrei Vagin <avagin@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Anthony Steinhauser <asteinhauser@google.com>,
Dave Martin <Dave.Martin@arm.com>,
Keno Fischer <keno@juliacomputing.com>
Subject: Re: [PATCH 3/3] selftest/arm64/ptrace: add tests for PTRACE_O_ARM64_RAW_REGS
Date: Wed, 10 Feb 2021 12:54:57 -0800 [thread overview]
Message-ID: <202102101253.300A11108@keescook> (raw)
In-Reply-To: <20210204154038.GC21058@willie-the-truck>
On Thu, Feb 04, 2021 at 03:40:39PM +0000, Will Deacon wrote:
> [+Kees]
>
> On Mon, Feb 01, 2021 at 11:40:12AM -0800, Andrei Vagin wrote:
> > Test output:
> > TAP version 13
> > 1..2
> > # selftests: arm64/ptrace: ptrace_syscall_raw_regs_test
> > # 1..2
> > # ok 1 x7: 686920776f726c64
> > # ok 2 The child exited with code 0.
> > # # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0
> > ok 1 selftests: arm64/ptrace: ptrace_syscall_raw_regs_test
> > # selftests: arm64/ptrace: ptrace_syscall_regs_test
> > # 1..3
> > # ok 1 x7: 0
> > # ok 2 x7: 1
> > # ok 3 The child exited with code 0.
> > # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
> > ok 2 selftests: arm64/ptrace: ptrace_syscall_regs_test
> >
> > Signed-off-by: Andrei Vagin <avagin@gmail.com>
> > ---
> > tools/testing/selftests/arm64/Makefile | 2 +-
> > tools/testing/selftests/arm64/ptrace/Makefile | 6 +
> > .../ptrace/ptrace_syscall_raw_regs_test.c | 142 +++++++++++++++++
> > .../arm64/ptrace/ptrace_syscall_regs_test.c | 150 ++++++++++++++++++
> > 4 files changed, 299 insertions(+), 1 deletion(-)
> > create mode 100644 tools/testing/selftests/arm64/ptrace/Makefile
> > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_raw_regs_test.c
> > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_regs_test.c
>
> Thanks for the tests!
>
> We already have a pretty extensive set of syscall entry tests in
> tools/testing/selftests/seccomp, so perhaps this would be better off as part
> of that? Maybe worth a look.
I'm happy with this living in either place -- I can make an argument
either way. If it's arm64-specific, maybe better to live outside of
seccomp?
--
Kees Cook
next prev parent reply other threads:[~2021-02-10 20:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 19:40 [PATCH 0/3 v2] arm64/ptrace: allow to get all registers on syscall traps Andrei Vagin
2021-02-01 19:40 ` [PATCH 1/3] arm64/ptrace: don't clobber task registers on syscall entry/exit traps Andrei Vagin
2021-02-04 15:23 ` Will Deacon
2021-02-04 16:41 ` Dave Martin
2021-02-25 16:00 ` Andrei Vagin
2021-02-01 19:40 ` [PATCH 2/3] arm64/ptrace: introduce PTRACE_O_ARM64_RAW_REGS Andrei Vagin
2021-02-04 15:36 ` Will Deacon
2021-02-08 18:31 ` Andrei Vagin
2021-02-01 19:40 ` [PATCH 3/3] selftest/arm64/ptrace: add tests for PTRACE_O_ARM64_RAW_REGS Andrei Vagin
2021-02-04 15:40 ` Will Deacon
2021-02-10 20:54 ` Kees Cook [this message]
2021-02-02 0:11 ` [PATCH 0/3 v2] arm64/ptrace: allow to get all registers on syscall traps Keno Fischer
2021-02-08 18:37 ` Andrei Vagin
2021-02-08 19:18 ` Keno Fischer
2021-02-04 14:53 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102101253.300A11108@keescook \
--to=keescook@chromium.org \
--cc=Dave.Martin@arm.com \
--cc=asteinhauser@google.com \
--cc=avagin@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=keno@juliacomputing.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).