From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BDCC43460 for ; Mon, 26 Apr 2021 06:40:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32181611CE for ; Mon, 26 Apr 2021 06:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbhDZGli (ORCPT ); Mon, 26 Apr 2021 02:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231907AbhDZGlh (ORCPT ); Mon, 26 Apr 2021 02:41:37 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72AAC061760 for ; Sun, 25 Apr 2021 23:40:56 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id w9so2747004lfr.12 for ; Sun, 25 Apr 2021 23:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ktn38akqcez+eAURfAHbs9UvpZXsngbkLRWEvsvsevA=; b=KayMu5PeYdfLUFqo5vYlIHf7ODXPP1ERnWjU7xBunZ72pM+jqoLZws9kWtWmrhtbA/ kq2IwojOFOIP/jftEtQovgK8VmSYrdCwnT6PiC0rkd9gdPpSOoKFQL4odQFrGIDRE/Kv N1Ufvcv03yXJceeiEMlnEp9g1SZz0wwbSZRcCqBOr0XMjEyFt8hdaq3DgW864/gEXU89 K3fwNujXtuvBafD4UcVTEmT4/v3e0u302kXjjGcPynulZuxdP+fZNfQ8P4XOF+Up1hzg PU5z+ouD8n0YLRjhLlsVdTm6rtdLCzgaCb2A5/76K0IdAVsNeCsbPIQd08QRltHdBrt6 wo1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ktn38akqcez+eAURfAHbs9UvpZXsngbkLRWEvsvsevA=; b=HOnO2+Lbr+aomwKbYrG98M85PbRka9vXOsQv2zmWzIo/kzKE48L+7tbNimCWrkUHRf JoXNJJk9ELcDkVl3gIGVqju3SMwcNijtldzK/09u7c9dKoUiwogejd71HUvr7apPTTiH AkYVGhBT8974NbeZ9/ZFc95Iq9gxzes7KU1eMTjfv02n95H/vvDx44iXJtKB/BNxkwf0 Xk1IGdsPEjbWMgd2t9i6woUEt0Wuwo07RlSG57ij6lx6xlWpiT8oETER3hAS2wjQphlK 1z7SD8bzairSZxkEc6G/vN4rDP1EmRCs/mpWreMM9MDwpryG1HOlKGvabKOY8g1NMM3x e3aw== X-Gm-Message-State: AOAM531tFGZF+h1VWW971g24QQut7eoouA92F0y8ChHqFPv0Gxqr59Qa Z6jFMP/2ehkPB/eF+xifLVR+sA== X-Google-Smtp-Source: ABdhPJxvWqen6pUox4dzq1wWTN3fSLNXj6T7VwTOk1mrgshFVnekjsx59dRA+YVMHbBNVUlsgx7Prw== X-Received: by 2002:ac2:5f53:: with SMTP id 19mr11971517lfz.17.1619419253303; Sun, 25 Apr 2021 23:40:53 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id f39sm1313321lfv.44.2021.04.25.23.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 23:40:52 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 4452D1026AB; Mon, 26 Apr 2021 09:40:56 +0300 (+03) Date: Mon, 26 Apr 2021 09:40:56 +0300 From: "Kirill A. Shutemov" To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Catalin Marinas , "Kirill A . Shutemov" , Vincenzo Frascino , Will Deacon Subject: Re: [PATCH v25 29/30] mm: Update arch_validate_flags() to include vma anonymous Message-ID: <20210426064056.bqbeekpsogd32yvm@box.shutemov.name> References: <20210415221419.31835-1-yu-cheng.yu@intel.com> <20210415221419.31835-30-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210415221419.31835-30-yu-cheng.yu@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Thu, Apr 15, 2021 at 03:14:18PM -0700, Yu-cheng Yu wrote: > When newer VM flags are being created, such as VM_MTE, it becomes necessary > for mmap/mprotect to verify if certain flags are being applied to an > anonymous VMA. > > To solve this, one approach is adding a VM flag to track that MAP_ANONYMOUS > is specified [1], and then using the flag in arch_validate_flags(). > > Another approach is passing vma_is_anonymous() to arch_validate_flags(). > To prepare the introduction of PROT_SHSTK, which creates a shadow stack > mapping and can only be applied to an anonymous VMA, update arch_validate_ > flags() to include anonymous VMA information. I would rather pass down whole vma. Who knows what else arch_validate_flags() would need to know about the VMA tomorrow: arch_validate_flags(vma, newflags); should do the trick. -- Kirill A. Shutemov