From: Eugene Syromiatnikov <esyr@redhat.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Steve Grubb <sgrubb@redhat.com>,
linux-audit@redhat.com,
strace development discussions <strace-devel@lists.strace.io>,
linux-api@vger.kernel.org, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv@strace.io
Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
Date: Thu, 2 Sep 2021 18:08:40 +0200 [thread overview]
Message-ID: <20210902160840.GA2220@asgard.redhat.com> (raw)
In-Reply-To: <20210902133529.GA32500@LAPTOP-UKSR4ENP.internal.baidu.com>
On Thu, Sep 02, 2021 at 09:35:29PM +0800, Cai Huoqing wrote:
> On 01 Sep 21 13:36:54, Steve Grubb wrote:
> > Hello,
> >
> > Thanks for the heads up.
> >
> > On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote:
> > > Adding linux-audit, strace-devel, and linux-api to CC:.
> > >
> > > On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
> > > > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
> > > > > commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
> > > > > indicated the ipx network layer as obsolete in Jan 2018,
> > > > > updated in the MAINTAINERS file
> > > > >
> > > > > now, after being exposed for 3 years to refactoring, so to
> > > > > delete uapi/linux/ipx.h and net/ipx.h header files for good.
> > > > > additionally, there is no module that depends on ipx.h except
> > > > > a broken staging driver(r8188eu)
> > > > >
> > > > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > > >
> > > > This removal breaks audit[1] and potentially breaks strace[2][3], at
> > > > least.
> >
> > I wouldn't say breaks so much as needs coordination with. :-) If ipx is
> > being dropped in its entirety, I can just make that part of the code
> > conditional to the header existing.
> >
> > -Steve
> IPX is marked obsolete for serveral years. so remove it and the
> dependency in linux tree.
> I'm sorry to not thinking about linux-audit and strace.
> Might you remove the dependency or make the part of the code.
> Many thanks.
Unfortunately, that is not how UAPI works. That change breaks building
of the existing code; one cannot change already released versions
of either audit, strace, or any other userspace program that happens
to unconditionally include <linux/ipx.h> without any fallback (like
<netipx/ipx.h> provided by glibc).
>
> -Cai
> >
> > > > [1]
> > > > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1
> > > > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2]
> > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > > > d7106d6b/src/net.c#L34 [3]
> > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > > > d7106d6b/src/sockaddr.c#L30
> >
> >
> >
> >
>
next prev parent reply other threads:[~2021-09-02 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210813120803.101-1-caihuoqing@baidu.com>
[not found] ` <20210813120803.101-2-caihuoqing@baidu.com>
[not found] ` <20210901160244.GA5957@asgard.redhat.com>
2021-09-01 16:52 ` [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Eugene Syromiatnikov
2021-09-01 17:36 ` Steve Grubb
2021-09-02 13:35 ` Cai Huoqing
2021-09-02 16:08 ` Eugene Syromiatnikov [this message]
2021-09-22 17:01 ` Paul Cercueil
2021-09-22 17:25 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902160840.GA2220@asgard.redhat.com \
--to=esyr@redhat.com \
--cc=caihuoqing@baidu.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=ldv@strace.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgrubb@redhat.com \
--cc=strace-devel@lists.strace.io \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).