From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD4CC4332F for ; Tue, 4 Oct 2022 04:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbiJDEyb (ORCPT ); Tue, 4 Oct 2022 00:54:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiJDEya (ORCPT ); Tue, 4 Oct 2022 00:54:30 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 218EE459B7 for ; Mon, 3 Oct 2022 21:54:29 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id gf8so9349627pjb.5 for ; Mon, 03 Oct 2022 21:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=0foMv+yNCzUvsFibuuhT0xJMSn3BsckwqQnYwsSpG6c=; b=kP2DU18OL+6JoMmHiz7PTfk7riy2/Rm9Wy/RMJSZw0+4OsYTh77f0vWl9qv7iajjKy RIz6U5V4DB8c8PdV0j+66I9QzpbtApMOuki0n8qXkaXGXt3gywvOawzFAo8PZUDgrvLn K6ewO49a2ZbsvxZhb+uN62IdqX2lQY719nEKM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=0foMv+yNCzUvsFibuuhT0xJMSn3BsckwqQnYwsSpG6c=; b=EkmuyH+7UFtK6L6XbV4ikiBvxjcFfLfJlvlaiowL7XqqTdaLUvujSLJe+a0awt6+En QUrZrN8s2IcOHrqG6NFLVo8vYQ+Vg343AXB8uuSS4rwYgyVbUOBCYQlJTN5HKadMcBXz zl4AyItVqzdVwN9SVvf+Ww69TeP4olbTjvfHKSI4TttAHwKaRy0Z0vAtN4SHoMHNVdWK 3Adl0hfpyrMMy8YMxmJjMVv3gUOUjd9eQZIvAxy7/s35QeWVjvNBxduHgMH5MrSlI1AW Lowe073SA9HuWFwGZtD3OnCAePW9TgeE3brOrOvbEvHz58utaGhTk9/23EPlpGuSGrGG QIpA== X-Gm-Message-State: ACrzQf2gcGEJfmKpNdWloorftKkpK6YybhRjM39/nmUeBdVBCQr6XH8E ABz/riAjXMIgdjj0JcqmviyC2Q== X-Google-Smtp-Source: AMsMyM7h1fPIVLatwHLhSPOimpTJ14eQWo/995Hwz/mCrD36Vca1l16aPrA63CLsA8WZ5DSuZ7p0tg== X-Received: by 2002:a17:90b:390e:b0:202:5d4e:c1f2 with SMTP id ob14-20020a17090b390e00b002025d4ec1f2mr15728874pjb.45.1664859268650; Mon, 03 Oct 2022 21:54:28 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y20-20020aa78f34000000b005617c676344sm2649775pfr.89.2022.10.03.21.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 21:54:27 -0700 (PDT) Date: Mon, 3 Oct 2022 21:54:26 -0700 From: Kees Cook To: Dave Hansen , "Gustavo A. R. Silva" , Nathan Chancellor , Nick Desaulniers Cc: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, Tom Lendacky , "Moger, Babu" Subject: Re: [PATCH v2 33/39] x86/cpufeatures: Limit shadow stack to Intel CPUs Message-ID: <202210032147.ED1310CEA8@keescook> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-34-rick.p.edgecombe@intel.com> <202210031656.23FAA3195@keescook> <559f937f-cab4-d408-6d95-fc85b4809aa9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559f937f-cab4-d408-6d95-fc85b4809aa9@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Oct 03, 2022 at 05:09:04PM -0700, Dave Hansen wrote: > On 10/3/22 16:57, Kees Cook wrote: > > On Thu, Sep 29, 2022 at 03:29:30PM -0700, Rick Edgecombe wrote: > >> Shadow stack is supported on newer AMD processors, but the kernel > >> implementation has not been tested on them. Prevent basic issues from > >> showing up for normal users by disabling shadow stack on all CPUs except > >> Intel until it has been tested. At which point the limitation should be > >> removed. > >> > >> Signed-off-by: Rick Edgecombe > > So running the selftests on an AMD system is sufficient to drop this > > patch? > > Yes, that's enough. > > I _thought_ the AMD folks provided some tested-by's at some point in the > past. But, maybe I'm confusing this for one of the other shared > features. Either way, I'm sure no tested-by's were dropped on purpose. > > I'm sure Rick is eager to trim down his series and this would be a great > patch to drop. Does anyone want to make that easy for Rick? > > Hey Gustavo, Nathan, or Nick! I know y'all have some fancy AMD testing rigs. Got a moment to spin up this series and run the selftests? :) -- Kees Cook