From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F03A1C4332F for ; Tue, 20 Dec 2022 07:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233755AbiLTHaM (ORCPT ); Tue, 20 Dec 2022 02:30:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233677AbiLTH3o (ORCPT ); Tue, 20 Dec 2022 02:29:44 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97E9417059; Mon, 19 Dec 2022 23:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671521355; x=1703057355; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=fjNSa0+921I8s8ST66iQKKAKKNcHFJo2C7vp0DyF6bU=; b=btMmDhriNUXIYE3RDC/D+VlLnxqJpYdVAtCnKG6Y00TuZKg18RKtoen/ ncKwhvbRaEWA1yueeu/7jrTKZZOoQBLg26c0Jt3b66l28RtiMKqyl9/ZK BgHqrpZBvLVYRk05frWTi7WjlYd3SqywoATxQxUttzwFkOdyx0XW+LztN CT8l4frasDPosl1OcaAHaow6ysNwW+VRk+KO1MvSkc8CdXfQLlS84LxHt PsQDsqnKCjOamEfvwz7swdwU6fxTOAEc4xaYAcKCHBhwLzFWG5Ik71Oci VCft7PHZkTWzSaxoNXv3sAK88Okxl6FcOPm9twU7H/ESpoxPiFwvgzL6V A==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="307230620" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="307230620" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 23:29:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="775191645" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="775191645" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga004.jf.intel.com with ESMTP; 19 Dec 2022 23:29:03 -0800 Date: Tue, 20 Dec 2022 15:24:46 +0800 From: Chao Peng To: Borislav Petkov Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 2/9] KVM: Introduce per-page memory attributes Message-ID: <20221220072446.GB1724933@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-3-chao.p.peng@linux.intel.com> <20221219081532.GD1691829@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Dec 19, 2022 at 11:17:22AM +0100, Borislav Petkov wrote: > On Mon, Dec 19, 2022 at 04:15:32PM +0800, Chao Peng wrote: > > Tamping down with error number a bit: > > > > if (attrs->flags) > > return -ENXIO; > > if (attrs->attributes & ~supported_attrs) > > return -EOPNOTSUPP; > > if (!PAGE_ALIGNED(attrs->address) || !PAGE_ALIGNED(attrs->size) || > > attrs->size == 0) > > return -EINVAL; > > if (attrs->address + attrs->size < attrs->address) > > return -E2BIG; > > Yap, better. > > I guess you should add those to the documentation of the ioctl too > so that people can find out why it fails. Or, well, they can look > at the code directly too but still... imagine some blurb about > user-friendliness here... Thanks for reminding. Yes KVM api doc is the right place to put these documentation in. Thanks, Chao > > :-) > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette