From: Jeff Layton <jlayton@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>, linux-fsdevel@vger.kernel.org
Cc: linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-api@vger.kernel.org,
linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v4 0/9] make statx() return DIO alignment information
Date: Fri, 26 Aug 2022 13:19:37 -0400 [thread overview]
Message-ID: <3543250c8157c3e0e7e410b268121e4d7d3e9bc2.camel@kernel.org> (raw)
In-Reply-To: <20220722071228.146690-1-ebiggers@kernel.org>
On Fri, 2022-07-22 at 00:12 -0700, Eric Biggers wrote:
> This patchset makes the statx() system call return direct I/O (DIO)
> alignment information. This allows userspace to easily determine
> whether a file supports DIO, and if so with what alignment restrictions.
>
> Patch 1 adds the basic VFS support for STATX_DIOALIGN. Patch 2 wires it
> up for all block device files. The remaining patches wire it up for
> regular files on ext4, f2fs, and xfs. Support for regular files on
> other filesystems can be added later.
>
> I've also written a man-pages patch, which I'm sending separately.
>
> Note, f2fs has one corner case where DIO reads are allowed but not DIO
> writes. The proposed statx fields can't represent this. My proposal
> (patch 6) is to just eliminate this case, as it seems much too weird.
> But I'd appreciate any feedback on that part.
>
> This patchset applies to v5.19-rc7.
>
> Changed v3 => v4:
> - Added xfs support.
>
> - Moved the helper function for block devices into block/bdev.c.
>
> - Adjusted the ext4 patch to not introduce a bug where misaligned DIO
> starts being allowed on encrypted files when it gets combined with
> the patch "iomap: add support for dma aligned direct-io" that is
> queued in the block tree for 5.20.
>
> - Made a simplification in fscrypt_dio_supported().
>
> Changed v2 => v3:
> - Dropped the stx_offset_align_optimal field, since its purpose
> wasn't clearly distinguished from the existing stx_blksize.
>
> - Renamed STATX_IOALIGN to STATX_DIOALIGN, to reflect the new focus
> on DIO only.
>
> - Similarly, renamed stx_{mem,offset}_align_dio to
> stx_dio_{mem,offset}_align, to reflect the new focus on DIO only.
>
> - Wired up STATX_DIOALIGN on block device files.
>
> Changed v1 => v2:
> - No changes.
>
> Eric Biggers (9):
> statx: add direct I/O alignment information
> vfs: support STATX_DIOALIGN on block devices
> fscrypt: change fscrypt_dio_supported() to prepare for STATX_DIOALIGN
> ext4: support STATX_DIOALIGN
> f2fs: move f2fs_force_buffered_io() into file.c
> f2fs: don't allow DIO reads but not DIO writes
> f2fs: simplify f2fs_force_buffered_io()
> f2fs: support STATX_DIOALIGN
> xfs: support STATX_DIOALIGN
>
> block/bdev.c | 25 ++++++++++++++++++++
> fs/crypto/inline_crypt.c | 49 +++++++++++++++++++--------------------
> fs/ext4/ext4.h | 1 +
> fs/ext4/file.c | 37 ++++++++++++++++++++---------
> fs/ext4/inode.c | 36 ++++++++++++++++++++++++++++
> fs/f2fs/f2fs.h | 45 -----------------------------------
> fs/f2fs/file.c | 45 ++++++++++++++++++++++++++++++++++-
> fs/stat.c | 14 +++++++++++
> fs/xfs/xfs_iops.c | 9 +++++++
> include/linux/blkdev.h | 4 ++++
> include/linux/fscrypt.h | 7 ++----
> include/linux/stat.h | 2 ++
> include/uapi/linux/stat.h | 4 +++-
> 13 files changed, 190 insertions(+), 88 deletions(-)
>
> base-commit: ff6992735ade75aae3e35d16b17da1008d753d28
Hi Eric,
Can I ask what your plans are with this set? I didn't see it in
linux-next yet, so I wasn't sure when you were looking to get it merged.
I'm working on patches to add a new statx field for the i_version
counter as well and I want to make sure that our work doesn't collide.
Thanks,
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-08-26 17:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 7:12 [PATCH v4 0/9] make statx() return DIO alignment information Eric Biggers
2022-07-22 7:12 ` [PATCH v4 1/9] statx: add direct I/O " Eric Biggers
2022-07-22 16:32 ` Darrick J. Wong
2022-07-22 17:31 ` Martin K. Petersen
2022-07-22 7:12 ` [PATCH v4 2/9] vfs: support STATX_DIOALIGN on block devices Eric Biggers
2022-07-22 8:10 ` Christoph Hellwig
2022-07-22 17:32 ` Martin K. Petersen
2022-07-22 7:12 ` [PATCH v4 3/9] fscrypt: change fscrypt_dio_supported() to prepare for STATX_DIOALIGN Eric Biggers
2022-07-22 8:10 ` Christoph Hellwig
2022-07-22 7:12 ` [PATCH v4 4/9] ext4: support STATX_DIOALIGN Eric Biggers
2022-07-22 17:05 ` Theodore Ts'o
2022-07-22 7:12 ` [PATCH v4 5/9] f2fs: move f2fs_force_buffered_io() into file.c Eric Biggers
2022-07-22 7:12 ` [PATCH v4 6/9] f2fs: don't allow DIO reads but not DIO writes Eric Biggers
2022-07-24 2:01 ` Jaegeuk Kim
2022-07-25 18:12 ` Eric Biggers
2022-07-25 23:58 ` Andreas Dilger
2022-07-31 3:08 ` Jaegeuk Kim
2022-08-16 0:55 ` Eric Biggers
2022-08-16 9:03 ` Dave Chinner
2022-08-16 16:42 ` Andreas Dilger
2022-08-19 23:09 ` Eric Biggers
2022-08-23 3:22 ` Andreas Dilger
2022-08-20 0:06 ` Jaegeuk Kim
2022-08-20 0:33 ` Eric Biggers
2022-08-21 8:53 ` Christoph Hellwig
2022-07-22 7:12 ` [PATCH v4 7/9] f2fs: simplify f2fs_force_buffered_io() Eric Biggers
2022-07-22 7:12 ` [PATCH v4 8/9] f2fs: support STATX_DIOALIGN Eric Biggers
2022-07-22 7:12 ` [PATCH v4 9/9] xfs: " Eric Biggers
2022-07-22 8:11 ` Christoph Hellwig
2022-07-22 16:24 ` Darrick J. Wong
2022-08-26 17:19 ` Jeff Layton [this message]
2022-08-27 7:07 ` [PATCH v4 0/9] make statx() return DIO alignment information Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3543250c8157c3e0e7e410b268121e4d7d3e9bc2.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ebiggers@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).