linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Michal Hocko <mhocko@kernel.org>
Cc: Joey Lee <jlee@suse.com>, Jiri Kosina <jkosina@suse.cz>,
	Kani Toshimitsu <toshi.kani@hpe.com>, Len Brown <lenb@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] acpi: drop support for force_remove
Date: Tue, 11 Apr 2017 00:15:42 +0200	[thread overview]
Message-ID: <3644128.Y1GtXNQdkv@aspire.rjw.lan> (raw)
In-Reply-To: <20170410171343.GO4618@dhcp22.suse.cz>

On Monday, April 10, 2017 07:13:44 PM Michal Hocko wrote:
> On Mon 03-04-17 09:40:23, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@suse.com>
> > 
> > /sys/firmware/acpi/hotplug/force_remove was presumably added to support
> > auto offlining in the past. This is, however, inherently dangerous for
> > some hotplugable resources like memory. The memory offlining fails when
> > the memory is still in use and cannot be dropped or migrated. If we
> > ignore the failure we are basically allowing for subtle memory
> > corruption or a crash.
> > 
> > We have actually noticed the later while hitting BUG() during the memory
> > hotremove (remove_memory):
> > 	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
> > 			check_memblock_offlined_cb);
> > 	if (ret)
> > 		BUG();
> > 
> > it took us quite non-trivial time realize that the customer had
> > force_remove enabled. Even if the BUG was removed here and we could
> > propagate the error up the call chain it wouldn't help at all because
> > then we would hit a crash or a memory corruption later and harder to
> > debug. So force_remove is unfixable for the memory hotremove. We haven't
> > checked other hotplugable resources to be prone to a similar problems.
> > 
> > Remove the force_remove functionality because it is not fixable currently.
> > Keep the sysfs file and report an error if somebody tries to enable it.
> > Encourage users to report about the missing functionality and work with
> > them with an alternative solution.
> > 
> > Reviewed-by: Lee, Chun-Yi <jlee@suse.com>
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
> 
> ping on this?

/shrug/

I'll apply it if nobody has any problems with it.

Thanks,
Rafael


  reply	other threads:[~2017-04-10 22:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03  7:40 [PATCH] acpi: drop support for force_remove Michal Hocko
2017-04-10 17:13 ` Michal Hocko
2017-04-10 22:15   ` Rafael J. Wysocki [this message]
2017-04-11 12:20     ` Michal Hocko
2017-04-11 13:48       ` Rafael J. Wysocki
     [not found]         ` <CAJZ5v0hhoej=FoqYaBOwy1-_AP35WyEYYUNkb3Pn22G0monanA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-11 13:52           ` Michal Hocko
2017-04-11 13:54             ` Rafael J. Wysocki
     [not found]               ` <CAJZ5v0hzv1oxpNJvSc2omqaOFRgiBB8UKCbRKGkgzHbEtqosbQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-14 22:33                 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3644128.Y1GtXNQdkv@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=jkosina@suse.cz \
    --cc=jlee@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=toshi.kani@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).