From: John Hubbard <jhubbard@nvidia.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
cl@linux.com, mhocko@suse.com, cai@lca.pw,
akpm@linux-foundation.org
Cc: linux-man@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes
Date: Tue, 17 Dec 2019 23:36:09 -0800 [thread overview]
Message-ID: <51dd767a-221f-882d-c7f6-45bd0c217a67@nvidia.com> (raw)
In-Reply-To: <092adc11-7039-9343-7067-0e0199c9dc13@gmail.com>
On 12/13/19 5:55 PM, Michael Kerrisk (man-pages) wrote:
...
>>> whoa, hold on. If I'm reading through the various error paths
>>> correctly, then this
>>> code is *never* going to return ENOENT for the whole function. It can
>>> fill in that
>>> value per-page, in the status array, but that's all. Did I get that
>>> right?
>>
>> Nice catch. Yes, you are right.
>>
>>>
>>> If so, we need to redo this part of the man page.
>>
>> Yes.
>
> So where are things at with this? Is an improved man-pages
> patch on the way, or is some other action (on the API) planned?
>
I was waiting to see if Yang was going to respond...anyway, I think
we're looking at approximately this sort of change:
diff --git a/man2/move_pages.2 b/man2/move_pages.2
index 2d96468fa..1bf1053f2 100644
--- a/man2/move_pages.2
+++ b/man2/move_pages.2
@@ -191,12 +191,6 @@ was specified or an attempt was made to migrate pages of a kernel thread.
.B ENODEV
One of the target nodes is not online.
.TP
-.B ENOENT
-No pages were found that require moving.
-All pages are either already
-on the target node, not present, had an invalid address or could not be
-moved because they were mapped by multiple processes.
-.TP
.B EPERM
The caller specified
.B MPOL_MF_MOVE_ALL
...But I'm not sure if we should change the implementation, instead, so
that it *can* return ENOENT. That's the main question to resolve before
creating any more patches, I think.
In addition, Michal mentioned that the page states in the status array also
need updated documentation.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2019-12-18 7:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 1:34 [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes Yang Shi
2019-12-06 1:47 ` John Hubbard
2019-12-06 7:47 ` Michal Hocko
2019-12-06 8:25 ` John Hubbard
2019-12-06 9:45 ` Michal Hocko
2019-12-06 17:31 ` Yang Shi
2019-12-06 18:00 ` Qian Cai
2019-12-06 18:19 ` Christopher Lameter
2019-12-06 17:26 ` Yang Shi
2019-12-14 1:55 ` Michael Kerrisk (man-pages)
2019-12-18 7:36 ` John Hubbard [this message]
2019-12-18 10:17 ` Michal Hocko
2019-12-31 3:00 ` Yang Shi
2019-12-31 3:49 ` Eric W. Biederman
2020-01-02 22:15 ` Yang Shi
2019-12-31 2:49 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51dd767a-221f-882d-c7f6-45bd0c217a67@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mtk.manpages@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).