From: Hans de Goede <hdegoede@redhat.com>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: Mark Gross <mgross@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>,
platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] platform/surface: Add DTX detachment system driver
Date: Wed, 17 Mar 2021 18:46:32 +0100 [thread overview]
Message-ID: <600b5161-e754-f363-b774-0cb020b7e439@redhat.com> (raw)
In-Reply-To: <20210308184819.437438-1-luzmaximilian@gmail.com>
Hi,
On 3/8/21 7:48 PM, Maximilian Luz wrote:
> The Microsoft Surface Book series devices consist of a so-called
> clipboard part (containing the CPU, touchscreen, and primary battery)
> and a base part (containing keyboard, secondary battery, and optional
> discrete GPU). These parts can be separated, i.e. the clipboard can be
> detached and used as tablet.
>
> This detachment process is managed by a subsystem of the Surface System
> Aggregator Module (SSAM). As that process is a bit more complex, i.e.
> can involve user interaction, it seems the best way to implement this is
> to provide a somewhat cleaned-up version of this interface to userspace.
>
> This series adds a driver (and documentation) for the detachment system
> which provides such an interface. See the commit message of the first
> patch for more details and a link to a user-space daemon using this
> interface. Support for the Surface Book 3 is added in patch 2,
> user-space API documentation in patch 3.
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>
> Regards,
> Max
>
> Maximilian Luz (3):
> platform/surface: Add DTX driver
> platform/surface: dtx: Add support for native SSAM devices
> docs: driver-api: Add Surface DTX driver documentation
>
> .../surface_aggregator/clients/dtx.rst | 718 +++++++++
> .../surface_aggregator/clients/index.rst | 1 +
> .../userspace-api/ioctl/ioctl-number.rst | 2 +
> MAINTAINERS | 8 +
> drivers/platform/surface/Kconfig | 20 +
> drivers/platform/surface/Makefile | 1 +
> drivers/platform/surface/surface_dtx.c | 1289 +++++++++++++++++
> include/uapi/linux/surface_aggregator/dtx.h | 146 ++
> 8 files changed, 2185 insertions(+)
> create mode 100644 Documentation/driver-api/surface_aggregator/clients/dtx.rst
> create mode 100644 drivers/platform/surface/surface_dtx.c
> create mode 100644 include/uapi/linux/surface_aggregator/dtx.h
>
prev parent reply other threads:[~2021-03-17 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 18:48 [PATCH 0/3] platform/surface: Add DTX detachment system driver Maximilian Luz
2021-03-08 18:48 ` [PATCH 1/3] platform/surface: Add DTX driver Maximilian Luz
2021-03-08 18:48 ` [PATCH 3/3] docs: driver-api: Add Surface DTX driver documentation Maximilian Luz
2021-03-17 17:46 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600b5161-e754-f363-b774-0cb020b7e439@redhat.com \
--to=hdegoede@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).