From: Jeff Layton <jlayton@kernel.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: viro@zeniv.linux.org.uk, linux-api@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Frank Filz <ffilzlnx@mindspring.com>
Subject: Re: [PATCH] vfs: report an inode version in statx for IS_I_VERSION inodes
Date: Tue, 23 Aug 2022 06:16:35 -0400 [thread overview]
Message-ID: <857b150cbd9c99134141475eafdc1e2b4e0ebe91.camel@kernel.org> (raw)
In-Reply-To: <87o7wb2s9d.fsf@oldenburg.str.redhat.com>
On Tue, 2022-08-23 at 12:01 +0200, Florian Weimer wrote:
> * Jeff Layton:
>
> > From: Jeff Layton <jlayton@redhat.com>
> >
> > The NFS server and IMA both rely heavily on the i_version counter, but
> > it's largely invisible to userland, which makes it difficult to test its
> > behavior. This value would also be of use to userland NFS servers, and
> > other applications that want a reliable way to know if there was an
> > explicit change to an inode since they last checked.
> >
> > Claim one of the spare fields in struct statx to hold a 64-bit inode
> > version attribute. This value must change with any explicit, observeable
> > metadata or data change. Note that atime updates are excluded from this,
> > unless it is due to an explicit change via utimes or similar mechanism.
> >
> > When statx requests this attribute on an IS_I_VERSION inode, do an
> > inode_query_iversion and fill the result in the field. Also, update the
> > test-statx.c program to display the inode version and the mountid.
>
> Will the version survive reboots? Is it stored on disks? Can backup
> tools (and others) use this to check if the file has changed since the
> last time the version has been observed?
>
The answer to all of those question is "yes".
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-08-23 13:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 11:56 [PATCH] vfs: report an inode version in statx for IS_I_VERSION inodes Jeff Layton
2022-08-23 10:01 ` Florian Weimer
2022-08-23 10:16 ` Jeff Layton [this message]
2022-08-23 21:53 ` Dave Chinner
2022-08-24 10:17 ` Jeff Layton
2022-08-25 18:48 ` Colin Walters
2022-08-25 19:48 ` Jeff Layton
2022-08-26 8:44 ` Colin Walters
2022-08-27 7:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857b150cbd9c99134141475eafdc1e2b4e0ebe91.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=dhowells@redhat.com \
--cc=ffilzlnx@mindspring.com \
--cc=fweimer@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).