From: Richard Palethorpe <rpalethorpe@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
linux-aio <linux-aio@kvack.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
the arch/x86 maintainers <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
LTP List <ltp@lists.linux.it>
Subject: Re: ia32 signed long treated as x64 unsigned int by __ia32_sys*
Date: Thu, 23 Sep 2021 11:01:09 +0100 [thread overview]
Message-ID: <87fstvlifu.fsf@suse.de> (raw)
In-Reply-To: <CAK8P3a2S=a0aw8GY8fZxaU5fz7ZkdehtHgStkn2=u9gO28GVEw@mail.gmail.com>
Hello Arnd,
Arnd Bergmann <arnd@arndb.de> writes:
> On Wed, Sep 22, 2021 at 10:46 AM Richard Palethorpe <rpalethorpe@suse.de> wrote:
>> Richard Palethorpe <rpalethorpe@suse.de> writes:
>
>> >
>> > Then the output is:
>> >
>> > [ 11.252268] io_pgetevents(f7f19000, 4294967295, 1, ...)
>> > [ 11.252401] comparing 4294967295 <= 1
>> > io_pgetevents02.c:114: TPASS: invalid min_nr: io_pgetevents() failed as expected: EINVAL (22)
>> > [ 11.252610] io_pgetevents(f7f19000, 1, 4294967295, ...)
>> > [ 11.252748] comparing 1 <= 4294967295
>> > io_pgetevents02.c:103: TFAIL: invalid max_nr: io_pgetevents() passed unexpectedly
>>
>> and below is the macro expansion for the automatically generated 32bit to
>> 64bit io_pgetevents. I believe it is casting u32 to s64, which appears
>> to mean there is no sign extension. I don't know if this is the expected
>> behaviour?
>
> Thank you for digging through this, I meant to already reply once more yesterday
> but didn't get around to that.
Thanks, no problem. I suppose this will effect other systemcalls as
well. Which if nothing else is a pain for testing.
>
>> __typeof(__builtin_choose_expr(
>> (__builtin_types_compatible_p(typeof((long)0), typeof(0LL)) ||
>> __builtin_types_compatible_p(typeof((long)0), typeof(0ULL))),
>> 0LL, 0L)) min_nr,
>> __typeof(__builtin_choose_expr(
>> (__builtin_types_compatible_p(typeof((long)0), typeof(0LL)) ||
>> __builtin_types_compatible_p(typeof((long)0), typeof(0ULL))),
>> 0LL, 0L)) nr,
>
> The part that I remembered is in arch/s390/include/asm/syscall_wrapper.h,
> which uses this version instead:
>
> #define __SC_COMPAT_CAST(t, a) \
> ({ \
> long __ReS = a; \
> \
> BUILD_BUG_ON((sizeof(t) > 4) && !__TYPE_IS_L(t) && \
> !__TYPE_IS_UL(t) && !__TYPE_IS_PTR(t) && \
> !__TYPE_IS_LL(t)); \
> if (__TYPE_IS_L(t)) \
> __ReS = (s32)a; \
> if (__TYPE_IS_UL(t)) \
> __ReS = (u32)a; \
> if (__TYPE_IS_PTR(t)) \
> __ReS = a & 0x7fffffff; \
> if (__TYPE_IS_LL(t)) \
> return -ENOSYS; \
> (t)__ReS; \
> })
>
> This also takes care of s390-specific pointer conversion, which is the
> reason for needing an architecture-specific wrapper, but I suppose the
> handling of signed arguments as done in s390 should also be done
> everywhere else.
>
> I also noticed that only x86 and s390 even have separate entry
> points for normal syscalls when called in compat mode, while
> the others all just zero the upper halves of the registers in the
> low-level entry code and then call the native entry point.
>
> Arnd
It looks to me like aarch64 also has something similar? At any rate, I
can try to fix it for x86 and investigate what else might be effected.
--
Thank you,
Richard.
next prev parent reply other threads:[~2021-09-23 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 13:01 [PATCH] aio: Wire up compat_sys_io_pgetevents_time64 for x86 Richard Palethorpe
2021-09-21 13:32 ` Arnd Bergmann
2021-09-21 14:05 ` Richard Palethorpe
2021-09-21 15:44 ` Richard Palethorpe
2021-09-22 8:45 ` ia32 signed long treated as x64 unsigned int by __ia32_sys* Richard Palethorpe
2021-09-22 9:35 ` Arnd Bergmann
2021-09-23 10:01 ` Richard Palethorpe [this message]
2021-09-23 10:25 ` Arnd Bergmann
2021-09-21 13:34 ` [LTP] [PATCH] aio: Wire up compat_sys_io_pgetevents_time64 for x86 Petr Vorel
2021-09-21 13:40 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fstvlifu.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=deepa.kernel@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).