linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping
@ 2017-09-14  9:42 John Ogness
  2017-09-14 14:51 ` Andy Lutomirski
       [not found] ` <87poatfwg6.fsf-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
  0 siblings, 2 replies; 7+ messages in thread
From: John Ogness @ 2017-09-14  9:42 UTC (permalink / raw)
  To: Andy Lutomirski
  Cc: Thomas Gleixner, Al Viro, Andrew Morton, Borislav Petkov,
	Brian Gerst, Kees Cook, Linus Torvalds, Linux API,
	Peter Zijlstra, Tetsuo Handa, Tycho Andersen, Ingo Molnar,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	stable-u79uwXL29TY76Z2rM5mHXA

Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in
/proc/PID/stat") stopped reporting eip/esp because it is
racey and dangerous for executing tasks. The comment adds:

    As far as I know, there are no use programs that make any
    material use of these fields, so just get rid of them.

However, existing userspace core-dump-handler applications (for
example, minicoredumper) are using these fields since they
provide an excellent cross-platform interface to these valuable
pointers. So that commit introduced a user space visible
regression.

Partially revert the change and make the readout possible for
tasks with the proper permissions and only if the target task
has the PF_DUMPCORE flag set.

Reported-by: Marco Felsch <marco.felsch-4vaI68m59Pc@public.gmane.org>
Signed-off-by: John Ogness <john.ogness-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Fixes: 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in> /proc/PID/stat")
---
 fs/proc/array.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index 88c3555..696cc68 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -421,7 +421,15 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
 		 * esp and eip are intentionally zeroed out.  There is no
 		 * non-racy way to read them without freezing the task.
 		 * Programs that need reliable values can use ptrace(2).
+		 *
+		 * The only exception is if the task is core dumping because
+		 * a program is not able to use ptrace(2) in that case. It is
+		 * safe because the task has stopped executing permanently.
 		 */
+		if (permitted && (task->flags & PF_DUMPCORE)) {
+			eip = KSTK_EIP(task);
+			esp = KSTK_ESP(task);
+		}
 	}
 
 	get_task_comm(tcomm, task);
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-15 21:36 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-14  9:42 [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping John Ogness
2017-09-14 14:51 ` Andy Lutomirski
     [not found] ` <87poatfwg6.fsf-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2017-09-14 15:37   ` Thomas Gleixner
2017-09-15 19:08     ` Linus Torvalds
2017-09-15 21:03       ` Ingo Molnar
2017-09-15 21:09   ` [tip:core/urgent] fs/proc: Report " tip-bot for John Ogness
2017-09-15 21:36   ` tip-bot for John Ogness

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).