From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FBD9C433B4 for ; Mon, 12 Apr 2021 09:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D68B6120B for ; Mon, 12 Apr 2021 09:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241155AbhDLJrE (ORCPT ); Mon, 12 Apr 2021 05:47:04 -0400 Received: from ozlabs.org ([203.11.71.1]:35405 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243343AbhDLJmC (ORCPT ); Mon, 12 Apr 2021 05:42:02 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4FJkK23pJvz9sCD; Mon, 12 Apr 2021 19:41:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1618220503; bh=qKUReVSabx2CuMNjbJlsyrB/4dzn/agdSM7iEVUdJFE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EI0crJes1a/+RqdpvZLEAvaeJSuKP8N8cwfdww93gWYxTDEwk/z7w5zNQZG5BAEZd ev3Jn5y9op0/i9JCxYb9TguxAMm8bB/voRAgJLL4Ijy05V7KcdYLFTXDKOke8vJbCS RjzGshVhLlUYRHa2SNMBvGbr1dFb2MSejY1iYDIauJls7QOB5ypl7lVgKongVwTmuD 7h+MR2KVudCiNQSNYaaKPV9eqVoxbvnpndlLZmB3u5KZfN+rX/LVphobTYVG53Z3+L d6f1izCOSt7lDm1hwVd+/bwDl0PSXgw/yDq+w0FxS9jnvnqXM2ThTwAITB7vaKbRMa 6M/gf3g51FSHQ== From: Michael Ellerman To: Alex Williamson , Christoph Hellwig Cc: Benjamin Herrenschmidt , Greg Kroah-Hartman , Jason Gunthorpe , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2 In-Reply-To: <20210406133805.715120bd@omen> References: <20210326061311.1497642-1-hch@lst.de> <20210326061311.1497642-2-hch@lst.de> <20210406133805.715120bd@omen> Date: Mon, 12 Apr 2021 19:41:41 +1000 Message-ID: <87y2dndelm.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org Alex Williamson writes: > On Fri, 26 Mar 2021 07:13:10 +0100 > Christoph Hellwig wrote: > >> This driver never had any open userspace (which for VFIO would include >> VM kernel drivers) that use it, and thus should never have been added >> by our normal userspace ABI rules. >> >> Signed-off-by: Christoph Hellwig >> Acked-by: Greg Kroah-Hartman >> --- >> drivers/vfio/pci/Kconfig | 6 - >> drivers/vfio/pci/Makefile | 1 - >> drivers/vfio/pci/vfio_pci.c | 18 - >> drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ---------------------------- >> drivers/vfio/pci/vfio_pci_private.h | 14 - >> include/uapi/linux/vfio.h | 38 +-- >> 6 files changed, 4 insertions(+), 563 deletions(-) >> delete mode 100644 drivers/vfio/pci/vfio_pci_nvlink2.c > > Hearing no objections, applied to vfio next branch for v5.13. Thanks, Looks like you only took patch 1? I can't take patch 2 on its own, that would break the build. Do you want to take both patches? There's currently no conflicts against my tree. It's possible one could appear before the v5.13 merge window, though it would probably just be something minor. Or I could apply both patches to my tree, which means patch 1 would appear as two commits in the git history, but that's not a big deal. cheers