linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: "Zach O'Keefe" <zokeefe@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-api@vger.kernel.org,
	Axel Rasmussen <axelrasmussen@google.com>,
	James Houghton <jthoughton@google.com>,
	Hugh Dickins <hughd@google.com>, Yang Shi <shy828301@gmail.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	David Hildenbrand <david@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Matthew Wilcox <willy@infradead.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Peter Xu <peterx@redhat.com>,
	Rongwei Wang <rongwei.wang@linux.alibaba.com>,
	SeongJae Park <sj@kernel.org>, Song Liu <songliubraving@fb.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Chris Kennelly <ckennelly@google.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Minchan Kim <minchan@kernel.org>,
	Patrick Xia <patrickx@google.com>
Subject: Re: [PATCH mm-unstable v4 05/10] selftests/vm: dedup THP helpers
Date: Tue, 27 Sep 2022 11:34:35 -0400	[thread overview]
Message-ID: <B6259986-56F7-4393-88F7-69DE839C53F2@nvidia.com> (raw)
In-Reply-To: <20220922224046.1143204-6-zokeefe@google.com>

[-- Attachment #1: Type: text/plain, Size: 2332 bytes --]

On 22 Sep 2022, at 18:40, Zach O'Keefe wrote:

> These files:
>
> tools/testing/selftests/vm/vm_util.c
> tools/testing/selftests/vm/khugepaged.c
>
> Both contain logic to:
>
> 1) Determine hugepage size on current system
> 2) Read /proc/self/smaps to determine number of THPs at an address
>
> Refactor selftests/vm/khugepaged.c to use the vm_util common helpers and
> add it as a build dependency.
>
> Since selftests/vm/khugepaged.c is the largest user of check_huge(),
> change the signature of check_huge() to match selftests/vm/khugepaged.c's
> useage: take an expected number of hugepages, and return a bool indicating
> if the correct number of hugepages were found.  Add a wrapper,
> check_huge_anon(), in anticipation of checking smaps for file and shmem
> hugepages.
>
> Update existing callsites to use the new pattern / function.
>
> Likewise, check_for_pattern() was duplicated, and it's a general enough
> helper to include in vm_util helpers as well.
>
> Link: https://lkml.kernel.org/r/20220907144521.3115321-6-zokeefe@google.com
> Signed-off-by: Zach O'Keefe <zokeefe@google.com>
> Cc: Axel Rasmussen <axelrasmussen@google.com>
> Cc: Chris Kennelly <ckennelly@google.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: James Houghton <jthoughton@google.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Miaohe Lin <linmiaohe@huawei.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Rongwei Wang <rongwei.wang@linux.alibaba.com>
> Cc: SeongJae Park <sj@kernel.org>
> Cc: Song Liu <songliubraving@fb.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Yang Shi <shy828301@gmail.com>
> ---
>  tools/testing/selftests/vm/Makefile           |  1 +
>  tools/testing/selftests/vm/khugepaged.c       | 64 ++-----------------
>  tools/testing/selftests/vm/soft-dirty.c       |  2 +-
>  .../selftests/vm/split_huge_page_test.c       | 12 ++--
>  tools/testing/selftests/vm/vm_util.c          | 26 +++++---
>  tools/testing/selftests/vm/vm_util.h          |  3 +-
>  6 files changed, 32 insertions(+), 76 deletions(-)

LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]

  reply	other threads:[~2022-09-27 15:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 22:40 [PATCH mm-unstable v4 00/10] mm: add file/shmem support to MADV_COLLAPSE Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 01/10] mm/shmem: add flag to enforce shmem THP in hugepage_vma_check() Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 02/10] mm/khugepaged: attempt to map file/shmem-backed pte-mapped THPs by pmds Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 03/10] mm/madvise: add file and shmem support to MADV_COLLAPSE Zach O'Keefe
2022-09-26 18:39   ` Yang Shi
2022-09-27  1:24     ` Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 04/10] mm/khugepaged: add tracepoint to hpage_collapse_scan_file() Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 05/10] selftests/vm: dedup THP helpers Zach O'Keefe
2022-09-27 15:34   ` Zi Yan [this message]
2022-09-27 16:32     ` Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 06/10] selftests/vm: modularize thp collapse memory operations Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 07/10] selftests/vm: add thp collapse file and tmpfs testing Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 08/10] selftests/vm: add thp collapse shmem testing Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 09/10] selftests/vm: add file/shmem MADV_COLLAPSE selftest for cleared pmd Zach O'Keefe
2022-09-22 22:40 ` [PATCH mm-unstable v4 10/10] selftests/vm: add selftest for MADV_COLLAPSE of uffd-minor memory Zach O'Keefe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B6259986-56F7-4393-88F7-69DE839C53F2@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=ckennelly@google.com \
    --cc=david@redhat.com \
    --cc=hughd@google.com \
    --cc=jthoughton@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=patrickx@google.com \
    --cc=peterx@redhat.com \
    --cc=rientjes@google.com \
    --cc=rongwei.wang@linux.alibaba.com \
    --cc=shy828301@gmail.com \
    --cc=sj@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=zokeefe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).