From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E300C433DF for ; Mon, 6 Jul 2020 08:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57A0720739 for ; Mon, 6 Jul 2020 08:54:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GwK48Ghm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728400AbgGFIy6 (ORCPT ); Mon, 6 Jul 2020 04:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728259AbgGFIy6 (ORCPT ); Mon, 6 Jul 2020 04:54:58 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1544BC08C5DF for ; Mon, 6 Jul 2020 01:54:58 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id h22so37179531lji.9 for ; Mon, 06 Jul 2020 01:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cNNvIPbyRDyhu5ZgEEiWbAIxYQhb/2gTkX3OL9Va+WQ=; b=GwK48GhmFmirpg3fdswa9lBUePOmYDIUGRR8hdVDdkSej4xaxCeCZAFSNgxfHMX6Yy w9Kla9Zz94g96jzu2SdkDHlz3/g7x+cSsfL0CLrYgCZP6J19zRAdLsZs87JfMO7sIJE6 hD8DhDJnDAm0DcZzdnRoijixEc6U2wSUxDKr/PyrnIZ6sDA3NJltPdTHsLduPer5Awad NUwH5K/XHmbz5gpeAqR5kYWsh2PSuS+J5l9UTHxPSnjzSl1GyAg/pMTCqSfzmJ/+quNd zVd7EeWl6Jy5ia0GEmuuMG516H4zo1kh4cHrXJacH0rZz+cmV3uWqvNIF5fVl3UCZoOV qcKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cNNvIPbyRDyhu5ZgEEiWbAIxYQhb/2gTkX3OL9Va+WQ=; b=RrjS072S70x+OPRpepjgUcioOc3NqrzA9zDFVtxv6aYe+nnpQLFYSycoHrgiAETqtn k00FLnYvRQoS7CV3HAV4KaAtS2xtCJl0I5rR7qsu556+BIQDEG3IZxkMsRKi2+ga5NSI hvxf4grrzO70BPoyeygVOLCzQthjs3zhVRthR2NxQQmqqKl9IJHa7RbPs77PwgHp1rdi waY3Mw9q65tVxN936sID4VHotSoMqo0CYBeENiuJj9mvt3PIrsihgxWgyCSwSRH+RMkN /NH8UyAXbhoem126S7YW//lqz/9Su54Gfkg+8EIAO1/j7jhsOdNubiMUcJTJ/cCfwf7x 2eDQ== X-Gm-Message-State: AOAM532krG3lA3aZG4mRxgaxn+pebcK/x3NvcC+wDyEyHOSLvJ7ARiFY /AEpo3mK/VScF4sQ9NEpgwa+EeNTkIqBlKXCtCpPFA== X-Google-Smtp-Source: ABdhPJylBq/GlipYoQiOaeWdyv7Nd1mhikRAHRzoHcrBYF2Tgt2xn3B345Rezd2yDNMo2CkzdbSQ8juxx+Oe1fm99VA= X-Received: by 2002:a2e:7a1a:: with SMTP id v26mr10720535ljc.104.1594025696518; Mon, 06 Jul 2020 01:54:56 -0700 (PDT) MIME-Version: 1.0 References: <20200529072017.2906-1-linus.walleij@linaro.org> In-Reply-To: From: Linus Walleij Date: Mon, 6 Jul 2020 10:54:45 +0200 Message-ID: Subject: Re: [PATCH v2] fcntl: Add 32bit filesystem mode To: "Theodore Ts'o" Cc: Andreas Dilger , Ext4 Developers List , linux-fsdevel , Linux API , QEMU Developers , Florian Weimer , Andy Lutomirski , Peter Maydell Content-Type: text/plain; charset="UTF-8" Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Tue, Jun 23, 2020 at 12:08 PM Peter Maydell wrote: > On Fri, 29 May 2020 at 08:22, Linus Walleij wrote: > > > > It was brought to my attention that this bug from 2018 was > > still unresolved: 32 bit emulators like QEMU were given > > 64 bit hashes when running 32 bit emulation on 64 bit systems. > > > > This adds a flag to the fcntl() F_GETFD and F_SETFD operations > > to set the underlying filesystem into 32bit mode even if the > > file handle was opened using 64bit mode without the compat > > syscalls. > > I somewhat belatedly got round to updating my QEMU patch > that uses this new fcntl() flag to fix the bug. Sorry for > the delay getting round to this. You can find the QEMU patch here: > https://patchew.org/QEMU/20200623100101.6041-1-peter.maydell@linaro.org/ > (it's an RFC because obviously we won't put it into QEMU until > the kernel side has gone upstream and the API is final.) > > What's the next step for moving this forward? Ted, can you merge this patch? It seems QEMU is happy and AFICT it uses the approach you want :) Yours, Linus Walleij