From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Matthew Garrett <matthewgarrett@google.com>,
James Morris James Morris <jmorris@namei.org>,
LSM List <linux-security-module@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown
Date: Fri, 11 Oct 2019 14:00:50 -0700 [thread overview]
Message-ID: <CAHk-=wiGtEDhwJab7+tQzmjDssynBruRvgj9NJY2bzNrVzw+0Q@mail.gmail.com> (raw)
In-Reply-To: <20191011165455.32666d53@gandalf.local.home>
On Fri, Oct 11, 2019 at 1:55 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> I guess I can keep it this way. Thoughts?
That looks fine to me. I'm still not sure you actually need to do all
this, but it doesn't look _wrong_.
That said, I still do think that if things are locked down from the
very get-go, tracefs_create_file() shouldn't even create the files.
That's mostly an independent thing from the "what about if they exists
and things got locked down afterwards", though.
I do wonder about the whole "well, if you started tracing before
locking things down, don't you want to see the end results"?
Linus
next prev parent reply other threads:[~2019-10-11 21:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 17:54 [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown Steven Rostedt
2019-10-11 18:20 ` Linus Torvalds
2019-10-11 18:36 ` Steven Rostedt
2019-10-11 19:24 ` Linus Torvalds
2019-10-11 19:50 ` Ben Hutchings
2019-10-11 21:46 ` Florian Weimer
2019-10-11 22:27 ` Steven Rostedt
2019-10-11 20:25 ` Steven Rostedt
2019-10-11 20:46 ` Linus Torvalds
2019-10-11 21:08 ` Steven Rostedt
2019-10-11 20:54 ` Steven Rostedt
2019-10-11 21:00 ` Linus Torvalds [this message]
2019-10-11 21:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiGtEDhwJab7+tQzmjDssynBruRvgj9NJY2bzNrVzw+0Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=jmorris@namei.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).