Linux-api Archive on lore.kernel.org
 help / color / Atom feed
From: Axel Rasmussen <axelrasmussen@google.com>
To: Hugh Dickins <hughd@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jerome Glisse <jglisse@redhat.com>, Joe Perches <joe@perches.com>,
	Lokesh Gidra <lokeshgidra@google.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Peter Xu <peterx@redhat.com>, Shaohua Li <shli@fb.com>,
	Shuah Khan <shuah@kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Wang Qing <wangqing@vivo.com>,
	linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-kselftest@vger.kernel.org, Linux MM <linux-mm@kvack.org>,
	Brian Geffon <bgeffon@google.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Mina Almasry <almasrymina@google.com>,
	Oliver Upton <oupton@google.com>
Subject: Re: [PATCH v3 00/10] userfaultfd: add minor fault handling for shmem
Date: Tue, 20 Apr 2021 14:28:36 -0700
Message-ID: <CAJHvVcifORTZx1tOrmPrqe5Ur9D1XqT9VFXHVzVrRYdEoJvhVA@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.11.2104151203320.15150@eggly.anvils>

On Thu, Apr 15, 2021 at 12:13 PM Hugh Dickins <hughd@google.com> wrote:
>
> On Thu, 15 Apr 2021, Axel Rasmussen wrote:
>
> > Base
> > ====
> >
> > This series is based on (and therefore should apply cleanly to) the tag
> > "v5.12-rc7-mmots-2021-04-11-20-49", additionally with Peter's selftest cleanup
> > series applied first:
> >
> > https://lore.kernel.org/patchwork/cover/1412450/
> >
> > Changelog
> > =========
> >
> > v2->v3:
> > - Picked up {Reviewed,Acked}-by's.
> > - Reorder commits: introduce CONTINUE before MINOR registration. [Hugh, Peter]
> > - Don't try to {unlock,put}_page an xarray value in shmem_getpage_gfp. [Hugh]
> > - Move enum mcopy_atomic_mode forward declare out of CONFIG_HUGETLB_PAGE. [Hugh]
> > - Keep mistakenly removed UFFD_USER_MODE_ONLY in selftest. [Peter]
> > - Cleanup context management in self test (make clear implicit, remove unneeded
> >   return values now that we have err()). [Peter]
> > - Correct dst_pte argument to dst_pmd in shmem_mcopy_atomic_pte macro. [Hugh]
> > - Mention the new shmem support feature in documentation. [Hugh]
>
> I shall ignore this v3 completely: "git send-email" is a wonderful
> tool for mailing out patchsets in quick succession, but I have not
> yet mastered "git send-review" to do the thinking for me as quickly.
>
> Still deliberating on 4/9 and 9/9 of v2: they're very close,
> but raise userfaultfd questions I still have to answer myself.

No problem at all, I'll send a v4 with the 4/9 and 9/9 updates on top
of this, and we can proceed from there, ignoring this version.

Sorry if I seem too eager. I really appreciate your reviews - each
time they are very thorough, and I learn a lot from the process.

>
> Hugh

      reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 18:47 Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 01/10] userfaultfd/hugetlbfs: avoid including userfaultfd_k.h in hugetlb.h Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 02/10] userfaultfd/shmem: combine shmem_{mcopy_atomic,mfill_zeropage}_pte Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 03/10] userfaultfd/shmem: support UFFDIO_CONTINUE for shmem Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 04/10] userfaultfd/shmem: support minor fault registration " Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 05/10] userfaultfd/selftests: use memfd_create for shmem test type Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 06/10] userfaultfd/selftests: create alias mappings in the shmem test Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 07/10] userfaultfd/selftests: reinitialize test context in each test Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 08/10] userfaultfd/selftests: exercise minor fault handling shmem support Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 09/10] userfaultfd/shmem: modify shmem_mcopy_atomic_pte to use install_ptes Axel Rasmussen
2021-04-15 18:47 ` [PATCH v3 10/10] userfaultfd: update documentation to mention shmem minor faults Axel Rasmussen
2021-04-15 19:12 ` [PATCH v3 00/10] userfaultfd: add minor fault handling for shmem Hugh Dickins
2021-04-20 21:28   ` Axel Rasmussen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJHvVcifORTZx1tOrmPrqe5Ur9D1XqT9VFXHVzVrRYdEoJvhVA@mail.gmail.com \
    --to=axelrasmussen@google.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=bgeffon@google.com \
    --cc=dgilbert@redhat.com \
    --cc=hughd@google.com \
    --cc=jglisse@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lokeshgidra@google.com \
    --cc=mike.kravetz@oracle.com \
    --cc=oupton@google.com \
    --cc=peterx@redhat.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=shli@fb.com \
    --cc=shuah@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wangqing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-api Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-api/0 linux-api/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-api linux-api/ https://lore.kernel.org/linux-api \
		linux-api@vger.kernel.org
	public-inbox-index linux-api

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-api


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git