linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter-/w4YWyX8dFk@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
	"ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org"
	<ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org>,
	Carlos O'Donell <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"open list:ABI/API"
	<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Thorsten Leemhuis <linux-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>,
	Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Thu, 6 Jul 2017 11:41:39 +0200	[thread overview]
Message-ID: <CAKMK7uFH+Kz8Mdph=J_FCZ4LC3tzoOmwNJPpSO+snTz6p0Xz+w@mail.gmail.com> (raw)
In-Reply-To: <20170706092836.ifcnc2qqwufndhdl-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Thu, Jul 6, 2017 at 11:28 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Jul 05, 2017 at 01:02:00PM -0400, Steven Rostedt wrote:
>> Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> wrote:
>
>> > If a test to reproduce a problem exists, it might be more beneficial to suggest
>> > to the patch submitter that it would be great if that test would be submitted
>> > as unit test instead of shaming that person for not doing so. Acknowledging and
>> > praising kselftest submissions might help more than shaming for non-submissions.
>
>> > My concern would be that once the shaming starts, it won't stop.
>
>> I think this is a communication issue. My word for "shaming" was to
>> call out a developer for not submitting a test. It wasn't about making
>> fun of them, or anything like that. I was only making a point
>> about how to teach people that they need to be more aware of the
>> testing infrastructure. Not about actually demeaning people.
>
> I think before anything like that is viable we need to show a concerted
> and visible interest in actually running the tests we already have and
> paying attention to the results - if people can see that they're just
> checking a checkbox that will often result in low quality tests which
> can do more harm than good.

+1. That pretty much means large-scale CI. The i915 test suite has
suffered quite a bit over the past years because the CI infrastructure
didn't keep up. Result is that running full CI kills pretty much every
platform there is eventually, and it's really hard to get back to a
state where the testsuite can be used to catch regressions again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  parent reply	other threads:[~2017-07-06  9:41 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <576cea07-770a-4864-c3f5-0832ff211e94@leemhuis.info>
     [not found] ` <576cea07-770a-4864-c3f5-0832ff211e94-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>
2017-07-03 16:30   ` [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking Steven Rostedt
     [not found]     ` <20170703123025.7479702e-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-03 18:50       ` Dan Williams
2017-07-04 19:03       ` Thorsten Leemhuis
     [not found]         ` <ad94dc65-cc9c-f4f1-27c1-5a48603c7f59-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>
2017-07-05 12:45           ` Steven Rostedt
     [not found]             ` <20170705084528.67499f8c-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 13:09               ` Carlos O'Donell
     [not found]                 ` <4080ecc7-1aa8-2940-f230-1b79d656cdb4-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-05 13:27                   ` Steven Rostedt
     [not found]                     ` <20170705092757.63dc2328-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 14:06                       ` Greg KH
     [not found]                         ` <20170705140607.GA30187-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-05 14:28                           ` Carlos O'Donell
2017-07-05 14:33                           ` Steven Rostedt
     [not found]                             ` <20170705103335.0cbd9984-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 14:52                               ` Mark Brown
2017-07-05 15:08                               ` Carlos O'Donell
     [not found]                                 ` <8c6843e8-73d9-a898-0366-0b72dfeb79a2-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-05 16:10                                   ` Steven Rostedt
     [not found]                                     ` <20170705121000.5430d7d0-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-06 11:34                                       ` Laurent Pinchart
2017-07-09 13:46                               ` Thorsten Leemhuis
2017-07-05 14:33                           ` Mark Brown
     [not found]                             ` <20170705143341.oees22k2snhtmkxo-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-07-05 14:36                               ` Steven Rostedt
     [not found]                                 ` <20170705103658.226099c6-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 14:50                                   ` James Bottomley
     [not found]                                     ` <1499266228.3668.10.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-07-05 14:56                                       ` Steven Rostedt
     [not found]                                         ` <20170705105651.5da9c969-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 15:09                                           ` James Bottomley
     [not found]                                             ` <1499267389.3668.16.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-07-05 15:20                                               ` Mark Brown
     [not found]                                                 ` <20170705152026.rkw73q2f6xmiju37-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-07-05 15:40                                                   ` Geert Uytterhoeven
2017-07-05 15:20                                               ` Steven Rostedt
     [not found]                                                 ` <20170705112047.23ee09f6-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 15:32                                                   ` James Bottomley
     [not found]                                                     ` <1499268748.3668.20.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-07-05 15:43                                                       ` Steven Rostedt
2017-07-05 18:24                                               ` Daniel Vetter
2017-07-05 18:17                                   ` Daniel Vetter
2017-07-05 15:16                           ` Guenter Roeck
     [not found]                             ` <a462fb3b-a6d4-e969-b301-b404981de224-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-07-05 15:27                               ` Steven Rostedt
     [not found]                                 ` <20170705112707.54d7f345-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 15:36                                   ` James Bottomley
     [not found]                                     ` <1499269015.3668.25.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-07-05 16:04                                       ` Steven Rostedt
     [not found]                                         ` <20170705120459.41e81f7b-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 16:58                                           ` James Bottomley
     [not found]                                             ` <1499273908.3668.30.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-07-05 17:07                                               ` Steven Rostedt
2017-07-05 16:48                                   ` Guenter Roeck
     [not found]                                     ` <c782a15a-4e73-7373-ca66-5b55e9406059-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-07-05 16:58                                       ` Dan Williams
2017-07-05 17:02                                       ` Steven Rostedt
     [not found]                                         ` <20170705130200.7c653f61-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-06  9:28                                           ` Mark Brown
     [not found]                                             ` <20170706092836.ifcnc2qqwufndhdl-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-07-06  9:41                                               ` Daniel Vetter [this message]
     [not found]                                                 ` <CAKMK7uFH+Kz8Mdph=J_FCZ4LC3tzoOmwNJPpSO+snTz6p0Xz+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 14:53                                                   ` Theodore Ts'o
     [not found]                                                     ` <20170706145346.6w2uzcf7xacbr3or-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2017-07-06 21:28                                                       ` Daniel Vetter
2017-07-06 14:48                                               ` James Bottomley
     [not found]                                                 ` <1499352485.2765.14.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-07-07 10:03                                                   ` Mark Brown
2017-07-31 16:54                                           ` Eric W. Biederman
     [not found]                                             ` <87zibkzgve.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-07-31 20:11                                               ` Steven Rostedt
     [not found]                                                 ` <20170731161123.4d1e80ac-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-31 20:12                                                   ` Eric W. Biederman
2017-08-02 16:53                                               ` Shuah Khan
     [not found]                                                 ` <fb399eba-91eb-21a5-e3f5-c3f919061c12-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-08-02 17:33                                                   ` Eric W. Biederman
     [not found]                                                     ` <87lgn1nac8.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-08-02 17:46                                                       ` Shuah Khan
     [not found]                                                         ` <61093c3f-6ad0-c033-a524-f2624f8d55ba-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-08-02 17:58                                                           ` Shuah Khan
2017-08-02 18:04                                                           ` Eric W. Biederman
     [not found]                                                             ` <87r2wtluc1.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-08-02 18:23                                                               ` Randy Dunlap
2017-08-02 18:42                                                               ` Shuah Khan
     [not found]                                                                 ` <92c31d6f-f98d-c764-eeec-bd0a2316d769-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-08-03  3:03                                                                   ` Theodore Ts'o
     [not found]                                                                     ` <20170803030327.gf7pl7foer3abdpe-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2017-08-03 17:42                                                                       ` Bird, Timothy
     [not found]                                                                         ` <ECADFF3FD767C149AD96A924E7EA6EAF3AD01BAB-t8YLG9SB9XQEb75RT/aEbJZPSYnAH24X@public.gmane.org>
2017-08-03 22:11                                                                           ` Shuah Khan
2017-08-03 18:51                                                                       ` Shuah Khan
     [not found]                                                                         ` <a313d401-d18b-ed9a-d82d-f6e12f606743-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-08-04  1:15                                                                           ` Theodore Ts'o
2017-07-07  3:33                                   ` Fengguang Wu
     [not found]                                     ` <20170707033302.rgpq5knzx3qvvr2p-q6ZYBFIlbFFi0tQiZxhdj1DQ4js95KgL@public.gmane.org>
2017-07-07  4:52                                       ` Frank Rowand
2017-07-05 15:32                               ` Greg KH
     [not found]                                 ` <20170705153259.GA7265-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-05 15:36                                   ` Carlos O'Donell
2017-07-05 15:52                                   ` Steven Rostedt
     [not found]                                     ` <20170705115219.02370220-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-05 18:42                                       ` Greg KH
2017-07-05 18:29                                   ` Daniel Vetter
2017-07-06 22:24                                   ` Shuah Khan
     [not found]                                     ` <a2fada39-76d4-e136-f2db-d8306d929902-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-07-06 22:32                                       ` Steven Rostedt
     [not found]                                         ` <20170706183249.60b2aef9-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-07-06 22:40                                           ` Shuah Khan
2017-07-05 16:54                           ` Dan Williams
     [not found]                             ` <CAPcyv4iOV2-hndx1rQmpPQF+myp=P8rmpf5JhXQXZxPhR6qoQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-05 18:45                               ` Greg KH
     [not found]                                 ` <20170705184544.GB22044-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-05 19:47                                   ` Dan Williams
2017-07-05 14:06                       ` Carlos O'Donell
2017-07-05 15:47                   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKMK7uFH+Kz8Mdph=J_FCZ4LC3tzoOmwNJPpSO+snTz6p0Xz+w@mail.gmail.com' \
    --to=daniel.vetter-/w4ywyx8dfk@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org \
    --cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
    --cc=shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).