From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping Date: Thu, 14 Sep 2017 07:51:59 -0700 Message-ID: References: <87poatfwg6.fsf@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <87poatfwg6.fsf@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: John Ogness Cc: Andy Lutomirski , Thomas Gleixner , Al Viro , Andrew Morton , Borislav Petkov , Brian Gerst , Kees Cook , Linus Torvalds , Linux API , Peter Zijlstra , Tetsuo Handa , Tycho Andersen , Ingo Molnar , "linux-kernel@vger.kernel.org" , stable List-Id: linux-api@vger.kernel.org On Thu, Sep 14, 2017 at 2:42 AM, John Ogness wrote: > Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in > /proc/PID/stat") stopped reporting eip/esp because it is > racey and dangerous for executing tasks. The comment adds: > > As far as I know, there are no use programs that make any > material use of these fields, so just get rid of them. > > However, existing userspace core-dump-handler applications (for > example, minicoredumper) are using these fields since they > provide an excellent cross-platform interface to these valuable > pointers. So that commit introduced a user space visible > regression. > > Partially revert the change and make the readout possible for > tasks with the proper permissions and only if the target task > has the PF_DUMPCORE flag set. Looks okay to me. Reviewed-by: Andy Lutomirski --Andy