From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54827C433B4 for ; Sat, 1 May 2021 10:35:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3495C601FF for ; Sat, 1 May 2021 10:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231961AbhEAKgd (ORCPT ); Sat, 1 May 2021 06:36:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231912AbhEAKgb (ORCPT ); Sat, 1 May 2021 06:36:31 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9BA9C06138B for ; Sat, 1 May 2021 03:35:40 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id t8so737383oij.0 for ; Sat, 01 May 2021 03:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bTlI6z8vmo0ApTJAefLbFgioHKc+K8OTZdLV1HoxLWY=; b=Fi/veP+riYdnYBcroOoHdp0w+G4l6nXmceQSUisY40BGdG5FxBV2lqjZLmi9UPiQGl FLNlAMXUMZn6iwibpySUr4IHlAAL7+exI8JG2nrCVuZIYQuYvDo4mxmqbZbNzdGGRbLG /N9+FL1SiGxs82j8H3KOZMcwtSFpSJlDKCuiQVnN6ky9vW/gqJyy7oalcYNs/PfvyVws 0ZRQM0ZwJ0sFo36fs4FULL6PJjA/FsXbApMg5EwZZMjI2MuT+OMGQ+Bt255jO6ZSo0WV tHBKD6FhjsbxqaPmgUlRlxuqxU0BbWcCiGy05YDsW0quVIJQtQID0uoWUHFNWD5rqLEM hygg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bTlI6z8vmo0ApTJAefLbFgioHKc+K8OTZdLV1HoxLWY=; b=Ip3qoDZdpvKe30GQJDjwhuTw60meDcZWNwD3nZ2fvs1Y27iz+qCMscsLFF6TSs6a/G woRgLYz4ICsc0RoTXTsCoNpjQYzjNzaaDNb07KAIW3TyaOwpk4w9ThsKLDUNt8MlAnOE X3fFyULCT+9NIJo1y/kSBFogvuV8iwir8VCyvqwVwU5Q4sykNs5ff+Hyp1OFvBoeF7yT Vc/yEfP55hV6GmTQ9QRfBkRFWqTpi0lL1p7fcUNRoAS5U+sEZsoucQsWHdwopIhzGK10 gglJWj2iPXLrmMJQzYrXRqVDcQPu1a1j+gEh5tgK6PTGJZIly20Caq/O4NlPI0P/3ZSD 5kQg== X-Gm-Message-State: AOAM531D3MpPVtmyXIvDSvAzMOQBUtUMncEjiga5T2f70ppayRgazyNm PbY/2vQwrpmo5HpB/bazH/0ryQrFVVTgBAFaYxxqjg== X-Google-Smtp-Source: ABdhPJxg5qa1WjYAQ1qDJp1BRy7nPfKGZCWOqMpRWLkbpR5sXctS+omrS1cgEFBccSeNB0ph9iwT30GiV9lKLmQhX/I= X-Received: by 2002:aca:bb06:: with SMTP id l6mr7103289oif.121.1619865339999; Sat, 01 May 2021 03:35:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Sat, 1 May 2021 12:35:28 +0200 Message-ID: Subject: Re: [PATCH 5/3] signal: Rename SIL_PERF_EVENT SIL_FAULT_PERF_EVENT for consistency To: "Eric W. Biederman" Cc: Arnd Bergmann , Florian Weimer , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Peter Collingbourne , Dmitry Vyukov , Alexander Potapenko , sparclinux , linux-arch , Linux Kernel Mailing List , Linux API , kasan-dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Sat, 1 May 2021 at 01:43, Eric W. Biederman wrote: > > It helps to know which part of the siginfo structure the siginfo_layout > value is talking about. Your Signed-off-by seems to be missing. Otherwise, Acked-by: Marco Elver > --- > fs/signalfd.c | 2 +- > include/linux/signal.h | 2 +- > kernel/signal.c | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/fs/signalfd.c b/fs/signalfd.c > index e87e59581653..83130244f653 100644 > --- a/fs/signalfd.c > +++ b/fs/signalfd.c > @@ -132,7 +132,7 @@ static int signalfd_copyinfo(struct signalfd_siginfo __user *uinfo, > new.ssi_addr = (long) kinfo->si_addr; > new.ssi_addr_lsb = (short) kinfo->si_addr_lsb; > break; > - case SIL_PERF_EVENT: > + case SIL_FAULT_PERF_EVENT: > new.ssi_addr = (long) kinfo->si_addr; > new.ssi_perf = kinfo->si_perf; > break; > diff --git a/include/linux/signal.h b/include/linux/signal.h > index 5160fd45e5ca..ed896d790e46 100644 > --- a/include/linux/signal.h > +++ b/include/linux/signal.h > @@ -44,7 +44,7 @@ enum siginfo_layout { > SIL_FAULT_MCEERR, > SIL_FAULT_BNDERR, > SIL_FAULT_PKUERR, > - SIL_PERF_EVENT, > + SIL_FAULT_PERF_EVENT, > SIL_CHLD, > SIL_RT, > SIL_SYS, > diff --git a/kernel/signal.c b/kernel/signal.c > index 0517ff950d38..690921960d8b 100644 > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -1198,7 +1198,7 @@ static inline bool has_si_pid_and_uid(struct kernel_siginfo *info) > case SIL_FAULT_MCEERR: > case SIL_FAULT_BNDERR: > case SIL_FAULT_PKUERR: > - case SIL_PERF_EVENT: > + case SIL_FAULT_PERF_EVENT: > case SIL_SYS: > ret = false; > break; > @@ -2553,7 +2553,7 @@ static void hide_si_addr_tag_bits(struct ksignal *ksig) > case SIL_FAULT_MCEERR: > case SIL_FAULT_BNDERR: > case SIL_FAULT_PKUERR: > - case SIL_PERF_EVENT: > + case SIL_FAULT_PERF_EVENT: > ksig->info.si_addr = arch_untagged_si_addr( > ksig->info.si_addr, ksig->sig, ksig->info.si_code); > break; > @@ -3242,7 +3242,7 @@ enum siginfo_layout siginfo_layout(unsigned sig, int si_code) > layout = SIL_FAULT_PKUERR; > #endif > else if ((sig == SIGTRAP) && (si_code == TRAP_PERF)) > - layout = SIL_PERF_EVENT; > + layout = SIL_FAULT_PERF_EVENT; > } > else if (si_code <= NSIGPOLL) > layout = SIL_POLL; > @@ -3364,7 +3364,7 @@ void copy_siginfo_to_external32(struct compat_siginfo *to, > to->si_addr = ptr_to_compat(from->si_addr); > to->si_pkey = from->si_pkey; > break; > - case SIL_PERF_EVENT: > + case SIL_FAULT_PERF_EVENT: > to->si_addr = ptr_to_compat(from->si_addr); > to->si_perf = from->si_perf; > break; > @@ -3440,7 +3440,7 @@ static int post_copy_siginfo_from_user32(kernel_siginfo_t *to, > to->si_addr = compat_ptr(from->si_addr); > to->si_pkey = from->si_pkey; > break; > - case SIL_PERF_EVENT: > + case SIL_FAULT_PERF_EVENT: > to->si_addr = compat_ptr(from->si_addr); > to->si_perf = from->si_perf; > break; > -- > 2.30.1 >