From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF206C433DB for ; Mon, 22 Mar 2021 15:13:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 671A46196E for ; Mon, 22 Mar 2021 15:13:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230046AbhCVPNN (ORCPT ); Mon, 22 Mar 2021 11:13:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:39578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231548AbhCVPMz (ORCPT ); Mon, 22 Mar 2021 11:12:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2B9861990; Mon, 22 Mar 2021 15:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616425965; bh=XaGJOXpYJ2i+MQsioxl6Tg28Kym8UEMe4b4RpcUBm8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I4suPRlqsJeGbJ3kRh4ME6/eP0O/yqXU+Rr96XxgbYcvuIrIDXw4eyoxUAx3shFY3 EKQL2w6YUEMhzsE51MWi0icihMdRehucbnlG5qw1sdZzfAj/vvYpPzhT2/9Vzwoh7k dHoP/0Vx5qwqfEnfs1Yzmdpu1roVfSG7U9Med5yw= Date: Mon, 22 Mar 2021 16:12:42 +0100 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Michael Ellerman , Alex Williamson , Benjamin Herrenschmidt , Jason Gunthorpe , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: remove the nvlink2 pci_vfio subdriver Message-ID: References: <20210322150155.797882-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322150155.797882-1-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Mar 22, 2021 at 04:01:53PM +0100, Christoph Hellwig wrote: > Hi all, > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > feature without any open source component - what would normally be > the normal open source userspace that we require for kernel drivers, > although in this particular case user space could of course be a > kernel driver in a VM. It also happens to be a complete mess that > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > and also pulles in over 1000 lines of code always build into powerpc > kernels that have Power NV support enabled. Because of all these > issues and the lack of breaking userspace when it is removed I think > the best idea is to simply kill. > > Diffstat: > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > b/arch/powerpc/include/asm/opal.h | 3 > b/arch/powerpc/include/asm/pci-bridge.h | 1 > b/arch/powerpc/include/asm/pci.h | 7 > b/arch/powerpc/platforms/powernv/Makefile | 2 > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > b/arch/powerpc/platforms/powernv/pci.c | 11 > b/arch/powerpc/platforms/powernv/pci.h | 17 > b/arch/powerpc/platforms/pseries/pci.c | 23 > b/drivers/vfio/pci/Kconfig | 6 > b/drivers/vfio/pci/Makefile | 1 > b/drivers/vfio/pci/vfio_pci.c | 18 > b/drivers/vfio/pci/vfio_pci_private.h | 14 > b/include/uapi/linux/vfio.h | 40 - > drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ > 16 files changed, 8 insertions(+), 1517 deletions(-) I thought this was supposed to be removed a few years ago! Anyway, no objection from me: Acked-by: Greg Kroah-Hartman