From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F7BC07E9A for ; Wed, 14 Jul 2021 12:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07E3D61289 for ; Wed, 14 Jul 2021 12:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239286AbhGNMEL (ORCPT ); Wed, 14 Jul 2021 08:04:11 -0400 Received: from mail-mw2nam10on2051.outbound.protection.outlook.com ([40.107.94.51]:30048 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230492AbhGNMEK (ORCPT ); Wed, 14 Jul 2021 08:04:10 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GtyYLmaAYy+tVJJbLzMvmG0gAPrcdx2UNH8u70yeCWGlHfpi/CBCEeZMZcd26LWqMD9U26MGS9kktQoCOfB6C63UEAm54L8jz0XzmhIGnDjJY850LEZIwb8bTDkR2Yp/+u5orjckHShFhQLkqPNAacZb+qWa2eY6WTx+SrvLIQuUDl/8UZTxQzPofo10fF7zITWeBIK09/1J0XZV9ezyh9/OSx9+UAC5AZ2LQQiiGwo2OfV2cKaU/FNdwDXH4NB2WQ25wQfO9r0dtXWlMxcpL8HI0De9B5Rd2mEGB/S4/ySnoZkMFwt/DUhBUpa3mt6kCtufC4GSu6TiDgnMmCv4tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Afk9pwx8zsfsMRAI1uzc5fLgBmmsPfPZAPCt3Nrfcxs=; b=G2y64mIlxPC4KGBNPEzlWH1U+4LcgQRjA7JHuJOBVovrm81mTnkY0jp/VZu8RfiSHf9nEiNW9T0A0vJol1SvdX51wNcWgAidFrMPodvjblgqRzzrAJ5hLuwQYc0KA1XEMrhaHfme+VFJBm3j/s3KM2V3fedwZ8QE0cn4dPV6Xq0EFHH/xAPYlLq5ChFti0EQyYBIHUaV5OoAY0k11GB5k8xCtz0C4aG+NXeU0AkYmiMCX/s+mKPKOUGvGgn0OdBAnChA8UPUukCPHJblwrRBm4b7HePcAhQQHgsfiFkd6/eaYRklwg7DnKgNhjMA2VhUATJZQrAJvWko1LShMeiMOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Afk9pwx8zsfsMRAI1uzc5fLgBmmsPfPZAPCt3Nrfcxs=; b=tjEZ8FQjGJqWaRtWzrrV2knn5dAGFHP8nI0+ywbc2Xkfa7BfOcD3UDdYCtH+XaXaCP7iiMRCdRpnU3ncPn3FcDDgw/RZcoSv3gpKt0IBVPQ7yH9LVQ4AGC800r2f4qFQzt2FyuRXOpgyJiZ6po3z0DBMlxZLY4ZvF4uyapUhMXx3EDK1PWPO3EIol3wxsWFtOoo9Rh1qlYGDyj8VIYJVAs0oAAV8ANsNEJnYsl9uBUMvdfrBsRxbRgx4Yse7VuDi4AA/I6qEHMn1nDE9Jd1mapyTkotlZ0rxIX60oYNp3Wr6deyfxDo7W+phlTmHgvB1xB15cByzy6ptViAmyU4kPg== Received: from BN6PR19CA0062.namprd19.prod.outlook.com (2603:10b6:404:e3::24) by MWHPR12MB1647.namprd12.prod.outlook.com (2603:10b6:301:c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Wed, 14 Jul 2021 12:01:17 +0000 Received: from BN8NAM11FT003.eop-nam11.prod.protection.outlook.com (2603:10b6:404:e3:cafe::2a) by BN6PR19CA0062.outlook.office365.com (2603:10b6:404:e3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Wed, 14 Jul 2021 12:01:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT003.mail.protection.outlook.com (10.13.177.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4331.21 via Frontend Transport; Wed, 14 Jul 2021 12:01:16 +0000 Received: from localhost (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 14 Jul 2021 12:01:15 +0000 Date: Wed, 14 Jul 2021 15:01:11 +0300 From: Leon Romanovsky To: Nitesh Narayan Lal CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 13/14] net/mlx5: Use irq_set_affinity_and_hint Message-ID: References: <20210713211502.464259-1-nitesh@redhat.com> <20210713211502.464259-14-nitesh@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210713211502.464259-14-nitesh@redhat.com> X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 797b4754-2ad9-49a3-ea44-08d946bf15fd X-MS-TrafficTypeDiagnostic: MWHPR12MB1647: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lHd8QiqpZAqYtLAnlPeVNhluLMUv7ZLOLrxyKbdLM2va1jb/KRejkIADZMVNCHcvGZ7p0NGXi8evV0PEyXNgAvPT1fER36ofobKa2IOyKRLtYB12bZgGLGRnuhj6iRNA0L+5RRphJx/KjyO9VmYrKApc+8OBhjGXGGsU9OLQKj7UGzGqFnveFz9o5mlUJwTsJ8nHEqM7/Ypxplm2F+ZQH4m5riJOlbJNz7FhoZn4pMKUEfB3F69qvTEsJSRb2Tm1pf6FByqVlhkE+8wF30ZahCIfqFZQx9MBKLrlfG6kMB/Uzd1CaVHEQCz+by51+oGtvN7PgClTee5W9i94A7Hd8zepPZEiNHnUrwOmXliSQBV3e2pjMTwaP+e/3o4sptZ/n2+AERc7ucB9FHqrDZSiJQShNigovmzlsAgEXV93X2Rpv6k876yJvbFj60tqWi+AZ4Kcn0ZupG+r1y2DlctGgk9/MsyUGcdixX999R9xiPmxKt70XqGKu/YPum2M2Fk+5bJ5J8ugef/PAZsKAn8jYqvglQfDQBV9uDzv2npHOjS4TYuwxj0rNSYJC0fw4NQFbXOhr/nyIW0mgY7zN9sbLTpoAkooOIyMa9VR8JdkszKkXQVvRNzKb+puYbYknGK1vwHPiRB5mpNkbLZSIdQg0F00wO9OlabyV+g0v54sZdn4M1qZYXkB+N6evm1C8PO2UNn5+BjqoIN4HI4Irl1fXNSYTNK+cyqS728duAlksBI= X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(7916004)(346002)(39860400002)(136003)(376002)(396003)(46966006)(36840700001)(2906002)(70206006)(478600001)(6666004)(26005)(36906005)(70586007)(186003)(16526019)(82740400003)(82310400003)(356005)(86362001)(5660300002)(7636003)(47076005)(8676002)(9686003)(4326008)(36860700001)(83380400001)(316002)(7366002)(33716001)(34020700004)(7406005)(8936002)(7416002)(426003)(6916009)(54906003)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 12:01:16.9526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 797b4754-2ad9-49a3-ea44-08d946bf15fd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT003.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1647 Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Tue, Jul 13, 2021 at 05:15:01PM -0400, Nitesh Narayan Lal wrote: > The driver uses irq_set_affinity_hint() to update the affinity_hint mask > that is consumed by the userspace to distribute the interrupts and to apply > the provided mask as the affinity for the mlx5 interrupts. However, > irq_set_affinity_hint() applying the provided cpumask as an affinity for > the interrupt is an undocumented side effect. > > To remove this side effect irq_set_affinity_hint() has been marked > as deprecated and new interfaces have been introduced. Hence, replace the > irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint() > where the provided mask needs to be applied as the affinity and > affinity_hint pointer needs to be set and replace with > irq_update_affinity_hint() where only affinity_hint needs to be updated. > > Signed-off-by: Nitesh Narayan Lal > --- > drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky