From: Leon Romanovsky <leonro@nvidia.com>
To: Nitesh Lal <nilal@redhat.com>
Cc: Nitesh Narayan Lal <nitesh@redhat.com>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-api@vger.kernel.org>, <linux-pci@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Ingo Molnar <mingo@kernel.org>, <jbrandeb@kernel.org>,
<frederic@kernel.org>, Juri Lelli <juri.lelli@redhat.com>,
Alex Belits <abelits@marvell.com>,
Bjorn Helgaas <bhelgaas@google.com>, <rostedt@goodmis.org>,
<peterz@infradead.org>, <davem@davemloft.net>,
<akpm@linux-foundation.org>, <sfr@canb.auug.org.au>,
<stephen@networkplumber.org>, <rppt@linux.vnet.ibm.com>,
<chris.friesen@windriver.com>, Marc Zyngier <maz@kernel.org>,
Neil Horman <nhorman@tuxdriver.com>, <pjwaskiewicz@gmail.com>,
Stefan Assmann <sassmann@redhat.com>,
Tomas Henzl <thenzl@redhat.com>, <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
<shivasharan.srikanteshwara@broadcom.com>,
<sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
<suganath-prabu.subramani@broadcom.com>,
<james.smart@broadcom.com>, <dick.kennedy@broadcom.com>,
Ken Cox <jkc@redhat.com>, <faisal.latif@intel.com>,
<shiraz.saleem@intel.com>, <tariqt@nvidia.com>,
Alaa Hleihel <ahleihel@redhat.com>, Kamal Heib <kheib@redhat.com>,
<borisp@nvidia.com>, <saeedm@nvidia.com>, <benve@cisco.com>,
<govind@gmx.com>, <jassisinghbrar@gmail.com>,
<ajit.khaparde@broadcom.com>,
<sriharsha.basavapatna@broadcom.com>,
<somnath.kotur@broadcom.com>,
"Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
Al Stone <ahs3@redhat.com>,
Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Subject: Re: [PATCH v3 06/14] RDMA/irdma: Use irq_set_affinity_and_hint
Date: Wed, 14 Jul 2021 16:02:56 +0300 [thread overview]
Message-ID: <YO7ggLW78FWE4z+1@unreal> (raw)
In-Reply-To: <CAFki+Lm-CpKZai1fV5aMJzEb-x+003m8wLQShSrYpyNh3XC50Q@mail.gmail.com>
On Wed, Jul 14, 2021 at 08:56:41AM -0400, Nitesh Lal wrote:
> On Wed, Jul 14, 2021 at 8:03 AM Leon Romanovsky <leonro@nvidia.com> wrote:
> >
> > On Tue, Jul 13, 2021 at 05:14:54PM -0400, Nitesh Narayan Lal wrote:
> > > The driver uses irq_set_affinity_hint() to update the affinity_hint mask
> > > that is consumed by the userspace to distribute the interrupts and to apply
> > > the provided mask as the affinity for its interrupts. However,
> > > irq_set_affinity_hint() applying the provided cpumask as an affinity for
> > > the interrupt is an undocumented side effect.
> > >
> > > To remove this side effect irq_set_affinity_hint() has been marked
> > > as deprecated and new interfaces have been introduced. Hence, replace the
> > > irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
> > > where the provided mask needs to be applied as the affinity and
> > > affinity_hint pointer needs to be set and replace with
> > > irq_update_affinity_hint() where only affinity_hint needs to be updated.
> > >
> > > Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
> > > ---
> > > drivers/infiniband/hw/irdma/hw.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
> > > index 7afb8a6a0526..7f13a051d4de 100644
> > > --- a/drivers/infiniband/hw/irdma/hw.c
> > > +++ b/drivers/infiniband/hw/irdma/hw.c
> > > @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
> > > struct irdma_sc_dev *dev = &rf->sc_dev;
> > >
> > > dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
> > > - irq_set_affinity_hint(msix_vec->irq, NULL);
> > > + irq_update_affinity_hint(msix_vec->irq, NULL);
> > > free_irq(msix_vec->irq, dev_id);
> > > }
> > >
> > > @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq,
> > > }
> > > cpumask_clear(&msix_vec->mask);
> > > cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
> > > - irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
> > > + irq_set_affinity_and_hint(msix_vec->irq, &msix_vec->mask);
> >
> > I think that it needs to be irq_update_affinity_hint().
> >
>
> Ah! I got a little confused from our last conversation about mlx5.
>
> IIUC mlx5 sub-function use case uses irdma (?) and that's why I thought
> that perhaps we would also want to define the affinity here from the beginning.
mlx5 is connected to mlx5_ib/mlx5_vdpa e.t.c.
Not sure about that, but I think that only mlx5 implements SIOV model.
>
> In any case, I will make the change and re-post.
>
> --
> Thanks
> Nitesh
>
next prev parent reply other threads:[~2021-07-14 13:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 21:14 [PATCH v3 00/14] genirq: Cleanup the usage of irq_set_affinity_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-13 21:51 ` Jesse Brandeburg
2021-07-13 21:14 ` [PATCH v3 03/14] i40e: " Nitesh Narayan Lal
2021-07-13 21:52 ` Jesse Brandeburg
2021-07-13 21:14 ` [PATCH v3 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 05/14] scsi: mpt3sas: " Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 06/14] RDMA/irdma: " Nitesh Narayan Lal
2021-07-14 12:03 ` Leon Romanovsky
2021-07-14 12:56 ` Nitesh Lal
2021-07-14 13:02 ` Leon Romanovsky [this message]
2021-07-15 13:25 ` Nitesh Lal
2021-07-13 21:14 ` [PATCH v3 07/14] enic: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 08/14] be2net: " Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 09/14] ixgbe: " Nitesh Narayan Lal
2021-07-13 22:01 ` Jesse Brandeburg
2021-07-13 21:14 ` [PATCH v3 10/14] mailbox: " Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-07-13 21:15 ` [PATCH v3 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-07-13 21:15 ` [PATCH v3 13/14] net/mlx5: " Nitesh Narayan Lal
2021-07-14 12:01 ` Leon Romanovsky
2021-07-13 21:15 ` [PATCH v3 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-14 11:19 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO7ggLW78FWE4z+1@unreal \
--to=leonro@nvidia.com \
--cc=abelits@marvell.com \
--cc=ahleihel@redhat.com \
--cc=ahs3@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=benve@cisco.com \
--cc=bhelgaas@google.com \
--cc=borisp@nvidia.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=chris.friesen@windriver.com \
--cc=davem@davemloft.net \
--cc=dick.kennedy@broadcom.com \
--cc=faisal.latif@intel.com \
--cc=frederic@kernel.org \
--cc=govind@gmx.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=james.smart@broadcom.com \
--cc=jassisinghbrar@gmail.com \
--cc=jbrandeb@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=jkc@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kashyap.desai@broadcom.com \
--cc=kheib@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nilal@redhat.com \
--cc=nitesh@redhat.com \
--cc=peterz@infradead.org \
--cc=pjwaskiewicz@gmail.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=saeedm@nvidia.com \
--cc=sassmann@redhat.com \
--cc=sathya.prakash@broadcom.com \
--cc=sfr@canb.auug.org.au \
--cc=shiraz.saleem@intel.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tariqt@nvidia.com \
--cc=tatyana.e.nikolova@intel.com \
--cc=tglx@linutronix.de \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).