From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9498C07E95 for ; Fri, 16 Jul 2021 11:50:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EFE5613D0 for ; Fri, 16 Jul 2021 11:50:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237131AbhGPLxI (ORCPT ); Fri, 16 Jul 2021 07:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234357AbhGPLxH (ORCPT ); Fri, 16 Jul 2021 07:53:07 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E75A3C06175F for ; Fri, 16 Jul 2021 04:50:11 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id f190so4087388wmf.4 for ; Fri, 16 Jul 2021 04:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nzabWvrTaM3dlhAMkGE1TPAE+zrQX3XHiWsmylmIlBU=; b=vZIQ2SoXPxosz3Bc9mWtUSTcZht3OswE1gyNYTdMwjAIrpVhZRfuRU+Dat7i7t2Q18 1PLnalJ3nd+LH1FIQZWVrAGH6bN43KDGKvuBvVQ0uknQ7NHcyNtlb3T0h2MCvMgfOwqn fXtOZGYnsXGzAC7V0zMi8MkHS1manK4/OJ1Axk1Ip3tOvv2AVridtc5f+umTDfqvVees IMQkIGSval7DAA/tXpX5NWiucWrcKyZUI+aVR/oBbHbZgiggfg4417x8OWtfgpeiZ77F tKu9txadr8mqRh2PQmCVkE6XX+s3I9loUxCI7XTTFw/Yn0d2vsBrWnt0TQjN8L8shwBy oJTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nzabWvrTaM3dlhAMkGE1TPAE+zrQX3XHiWsmylmIlBU=; b=i27dC6OWtpkow+vePcB1BEGxn8OVN1wT5OWkOb2mTcJ5RD8svsI6eMGhMyTaBhVW3i DpOlLWMXA7DYnQRyGil10qbcyqdVuH4KMGnkvt9P2T68Anf6cXy0FsJq4NJdrRv4XXkI GoZcy1h+YIvy1aeVyaW5lEpcxb53B3xHNnYWxPjInFvcJ1EX5ELbPFgL07mT/oPs85WS vtsd1k1QmbLQl4av9ujw50xuq0ZrkoUICKEVohUBWJ+sww63tk/yXb+Jw34TCqYjFYK1 KdZsgC8KO86TIoSbuxpR4MNQIU5+yIMGLM06MuFbjv2xpNWiP6hxIh9L19gDBQxSvGP4 jFpw== X-Gm-Message-State: AOAM530uy5JBUI4TdlskzOre1IzNwKbLgOKuZfvoiNmzgyKWtZ/EmZpo wy7ix+kkmTxCBNKMY/J4Dg4XfQ== X-Google-Smtp-Source: ABdhPJz90bjV8HNPkHQzMz/XoPtiqek4tWIDIT6qDxVDzEa6QFp1dFA6Swhn79pbKl14mnyKnqqj0g== X-Received: by 2002:a1c:39d5:: with SMTP id g204mr16168668wma.66.1626436210180; Fri, 16 Jul 2021 04:50:10 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:fb3b:45b4:a42a:5668]) by smtp.gmail.com with ESMTPSA id k24sm10147181wrh.30.2021.07.16.04.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 04:50:09 -0700 (PDT) Date: Fri, 16 Jul 2021 13:50:04 +0200 From: Marco Elver To: "Eric W. Biederman" Cc: Arnd Bergmann , Florian Weimer , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Peter Collingbourne , Dmitry Vyukov , Alexander Potapenko , sparclinux , linux-arch , Linux Kernel Mailing List , Linux API , kasan-dev Subject: Re: [PATCH 0/6] Final si_trapno bits Message-ID: References: <87a6mnzbx2.fsf_-_@disp2133> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a6mnzbx2.fsf_-_@disp2133> User-Agent: Mutt/2.0.5 (2021-01-21) Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Thu, Jul 15, 2021 at 01:09PM -0500, Eric W. Biederman wrote: > As a part of a fix for the ABI of the newly added SIGTRAP TRAP_PERF a > si_trapno was reduced to an ordinary extention of the _sigfault case > of struct siginfo. > > When Linus saw the complete set of changes come in as a fix he requested > that the set of changes be trimmed down to just what was necessary to > fix the SIGTRAP TRAP_PERF ABI. > > I had intended to get the rest of the changes into the merge window for > v5.14 but I dropped the ball. > > I have made the changes to stop using __ARCH_SI_TRAPNO be per > architecture so they are easier to review. In doing so I found one > place on alpha where I used send_sig_fault instead of > send_sig_fault_trapno(... si_trapno = 0). That would not have changed > the userspace behavior but it did make the kernel code less clear. > > My rule in these patches is everywhere that siginfo layout calls > for SIL_FAULT_TRAPNO the code uses either force_sig_fault_trapno > or send_sig_fault_trapno. > > And of course I have rebased and compile tested Marco's compile time > assert patches. > > Eric > > > Eric W. Biederman (3): > signal/sparc: si_trapno is only used with SIGILL ILL_ILLTRP > signal/alpha: si_trapno is only used with SIGFPE and SIGTRAP TRAP_UNK > signal: Remove the generic __ARCH_SI_TRAPNO support > > Marco Elver (3): > sparc64: Add compile-time asserts for siginfo_t offsets > arm: Add compile-time asserts for siginfo_t offsets > arm64: Add compile-time asserts for siginfo_t offsets Nice, thanks for the respin. If I diffed it right, I see this is almost (modulo what you mentioned above) equivalent to: https://lore.kernel.org/linux-api/m1tuni8ano.fsf_-_@fess.ebiederm.org/ + what's already in mainline. It's only missing: signal: Verify the alignment and size of siginfo_t signal: Rename SIL_PERF_EVENT SIL_FAULT_PERF_EVENT for consistency Would this be appropriate for this series, or rather separately, or dropped completely? Thanks, -- Marco