From: Prakash Sangappa <prakash.sangappa@oracle.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org, rppt@linux.vnet.ibm.com,
akpm@linux-foundation.org, mike.kravetz@oracle.com
Subject: Re: [RESEND PATCH 2/2] userfaultfd: selftest: Add tests for UFFD_FREATURE_SIGBUS
Date: Wed, 26 Jul 2017 12:02:31 -0700 [thread overview]
Message-ID: <a0cb715f-8652-2526-5580-69aa4ea0e25f@oracle.com> (raw)
In-Reply-To: <20170726142723.GW29716@redhat.com>
On 7/26/17 7:27 AM, Andrea Arcangeli wrote:
> On Tue, Jul 25, 2017 at 12:47:42AM -0400, Prakash Sangappa wrote:
>> Signed-off-by: Prakash Sangappa <prakash.sangappa@oracle.com>
>> ---
>> tools/testing/selftests/vm/userfaultfd.c | 121 +++++++++++++++++++++++++++++-
>> 1 files changed, 118 insertions(+), 3 deletions(-)
> Like Mike said, some comment about the test would be better, commit
> messages are never one liners in the kernel.
Ok
>
>> @@ -408,6 +409,7 @@ static int copy_page(int ufd, unsigned long offset)
>> userfaults++;
>> break;
>> case UFFD_EVENT_FORK:
>> + close(uffd);
>> uffd = msg.arg.fork.ufd;
>> pollfd[0].fd = uffd;
>> break;
> Isn't this fd leak bugfix independent of the rest of the changes? The
> only side effects should have been that it could run out of fds, but I
> assume this was found by source review as I doubt it could run out of fds.
> This could be splitted off in a separate patch.
Not just the fd leak, it causes problems here with the addition of the
new test userfaultfd_sig_test(). Since the original vma registration
persists in the parent, subsequent registration in userfaultfd_events_test()
fails with 'EBUSY' error, as userfault implementation does not allow
registering same vma with another uffd, while one exists.
Therefore, will need this change. I could just leave this fix here along
with the rest of the changes, will that be ok?
-Prakash
> Overall it looks a good test also exercising UFFD_EVENT_FORK at the
> same time.
>
> Thanks,
> Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-07-26 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 4:47 [RESEND PATCH 0/2] userfaultfd: Add feature to request for a signal delivery Prakash Sangappa
2017-07-25 4:47 ` [RESEND PATCH 1/2] " Prakash Sangappa
2017-07-26 7:54 ` Mike Rapoport
2017-07-26 14:19 ` Andrea Arcangeli
2017-07-27 11:58 ` Michal Hocko
2017-07-28 1:13 ` Prakash Sangappa
2017-07-25 4:47 ` [RESEND PATCH 2/2] userfaultfd: selftest: Add tests for UFFD_FREATURE_SIGBUS Prakash Sangappa
2017-07-26 7:53 ` Mike Rapoport
2017-07-26 18:54 ` Prakash Sangappa
2017-07-26 14:27 ` Andrea Arcangeli
2017-07-26 19:02 ` Prakash Sangappa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0cb715f-8652-2526-5580-69aa4ea0e25f@oracle.com \
--to=prakash.sangappa@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).