From mboxrd@z Thu Jan 1 00:00:00 1970 From: Goldwyn Rodrigues Subject: Re: [PATCH 0/10 v9] No wait AIO Date: Sun, 28 May 2017 21:38:27 -0500 Message-ID: References: <20170524164150.9492-1-rgoldwyn@suse.de> <20170528092728.GA14519@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170528092728.GA14519@infradead.org> Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, jack@suse.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, axboe@kernel.dk, linux-api@vger.kernel.org, adam.manzanares@wdc.com, viro@zeniv.linux.org.uk List-Id: linux-api@vger.kernel.org On 05/28/2017 04:27 AM, Christoph Hellwig wrote: >> Changes since v8: >> + Err out AIO reads with -EINVAL flagged as RWF_NOWAIT > > Ugg, why? Reads aren't really treated any different than writes in > the direct I/O code. This effort focused on writes only. >>From the point of view of the application/user, reads are usually required to complete with success. I don't see a scenario where reads() would need the nowait feature. If there is a use case, I'd be happy to add and support it. -- Goldwyn