From: Mike Kravetz <mike.kravetz@oracle.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Linux API <linux-api@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Aaron Lu <aaron.lu@intel.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] mm/mremap: Fail map duplication attempts for private mappings
Date: Fri, 21 Jul 2017 14:18:31 -0700 [thread overview]
Message-ID: <cb9d9f6a-7095-582f-15a5-62643d65c736@oracle.com> (raw)
In-Reply-To: <20170721143644.GC5944@dhcp22.suse.cz>
On 07/21/2017 07:36 AM, Michal Hocko wrote:
> On Thu 20-07-17 13:37:59, Mike Kravetz wrote:
>> mremap will create a 'duplicate' mapping if old_size == 0 is
>> specified. Such duplicate mappings make no sense for private
>> mappings.
>
> sorry for the nit picking but this is not true strictly speaking.
> It makes some sense, arguably (e.g. take an atomic snapshot of the
> mapping). It doesn't make any sense with the _current_ implementation.
>
>> If duplication is attempted for a private mapping,
>> mremap creates a separate private mapping unrelated to the
>> original mapping and makes no modifications to the original.
>> This is contrary to the purpose of mremap which should return
>> a mapping which is in some way related to the original.
>>
>> Therefore, return EINVAL in the case where if an attempt is
>> made to duplicate a private mapping. Also, print a warning
>> message (once) if such an attempt is made.
>>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>
> I do not insist on the comment update suggested
> http://lkml.kernel.org/r/20170720082058.GF9058@dhcp22.suse.cz
> but I would appreciate it...
>
> Other than that looks reasonably to me
>
> Acked-by: Michal Hocko <mhocko@suse.com>
My apologies. I overlooked your comment about the comment when
creating the patch. Below is the patch with commit message and
comment updated.
>From 5c4a1602bd6a942544ed011dc0a72fd258e874b2 Mon Sep 17 00:00:00 2001
From: Mike Kravetz <mike.kravetz@oracle.com>
Date: Wed, 12 Jul 2017 13:52:47 -0700
Subject: [PATCH] mm/mremap: Fail map duplication attempts for private mappings
mremap will attempt to create a 'duplicate' mapping if old_size
== 0 is specified. In the case of private mappings, mremap
will actually create a fresh separate private mapping unrelated
to the original. This does not fit with the design semantics of
mremap as the intention is to create a new mapping based on the
original.
Therefore, return EINVAL in the case where an attempt is made
to duplicate a private mapping. Also, print a warning message
(once) if such an attempt is made.
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
mm/mremap.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/mm/mremap.c b/mm/mremap.c
index cd8a1b1..75b167d 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -383,6 +383,19 @@ static struct vm_area_struct *vma_to_resize(unsigned long addr,
if (!vma || vma->vm_start > addr)
return ERR_PTR(-EFAULT);
+ /*
+ * !old_len is a special case where an attempt is made to 'duplicate'
+ * a mapping. This makes no sense for private mappings as it will
+ * instead create a fresh/new mapping unrelated to the original. This
+ * is contrary to the basic idea of mremap which creates new mappings
+ * based on the original. There are no known use cases for this
+ * behavior. As a result, fail such attempts.
+ */
+ if (!old_len && !(vma->vm_flags & (VM_SHARED | VM_MAYSHARE))) {
+ pr_warn_once("%s (%d): attempted to duplicate a private mapping with mremap. This is not supported.\n", current->comm, current->pid);
+ return ERR_PTR(-EINVAL);
+ }
+
if (is_vm_hugetlb_page(vma))
return ERR_PTR(-EINVAL);
--
2.7.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-21 21:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1499961495-8063-1-git-send-email-mike.kravetz@oracle.com>
[not found] ` <1499961495-8063-1-git-send-email-mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-07-13 19:11 ` [PATCH] mm/mremap: Fail map duplication attempts for private mappings Vlastimil Babka
2017-07-13 22:33 ` Mike Kravetz
2017-07-14 4:51 ` Anshuman Khandual
[not found] ` <415625d2-1be9-71f0-ca11-a014cef98a3f-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-07-14 8:26 ` Michal Hocko
2017-07-14 17:29 ` Mike Kravetz
2017-07-17 6:44 ` Michal Hocko
2017-07-19 16:39 ` Mike Kravetz
2017-07-20 8:20 ` Michal Hocko
2017-07-20 20:37 ` [PATCH v2] " Mike Kravetz
2017-07-21 14:36 ` Michal Hocko
2017-07-21 21:18 ` Mike Kravetz [this message]
[not found] ` <cb9d9f6a-7095-582f-15a5-62643d65c736-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-07-24 8:50 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb9d9f6a-7095-582f-15a5-62643d65c736@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).