From mboxrd@z Thu Jan 1 00:00:00 1970 From: Goldwyn Rodrigues Subject: Re: [PATCH 6/8] nowait aio: ext4 Date: Tue, 4 Apr 2017 13:41:09 -0500 Message-ID: References: <20170403185307.6243-1-rgoldwyn@suse.de> <20170403185307.6243-7-rgoldwyn@suse.de> <20170404075853.GB28522@quack2.suse.cz> <20170404084122.GA10252@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170404084122.GA10252@infradead.org> Sender: linux-btrfs-owner@vger.kernel.org To: Christoph Hellwig , Jan Kara Cc: linux-fsdevel@vger.kernel.org, jack@suse.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, sagi@grimberg.me, avi@scylladb.com, axboe@kernel.dk, linux-api@vger.kernel.org, willy@infradead.org, tom.leiming@gmail.com, Goldwyn Rodrigues List-Id: linux-api@vger.kernel.org On 04/04/2017 03:41 AM, Christoph Hellwig wrote: > On Tue, Apr 04, 2017 at 09:58:53AM +0200, Jan Kara wrote: >> FS_NOWAIT looks a bit too generic given these are filesystem feature flags. >> Can we call it FS_NOWAIT_IO? > > It's way to generic as it's a feature of the particular file_operations > instance. But once we switch to using RWF_* we can just the existing > per-op feature checks for thos and the per-fs flag should just go away. > I am working on incorporating RWF_* flags. However, I am not sure how RWF_* flags would get rid of FS_NOWAIT/FS_NOWAIT_IO. Since most of "blocking" information is with the filesystem, it is a per-filesystem flag to block out (EOPNOTSUPP) the filesystems which do not support it. -- Goldwyn