linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
To: Joe Richey <joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-fscrypt-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Richard Weinberger
	<richard.weinberger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Jaegeuk Kim <jaegeuk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
	Michael Halcrow
	<mhalcrow-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Joe Richey <joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2] fscrypt: Remove __packed from fscrypt_policy
Date: Fri, 7 Apr 2017 11:22:58 +0200	[thread overview]
Message-ID: <d6e1c40b-ad3d-bf8f-5adc-d0d123e7a28e@nod.at> (raw)
In-Reply-To: <20170406231428.154187-1-joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Am 07.04.2017 um 01:14 schrieb Joe Richey:
> From: Joe Richey <joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> 
> This commit removes __packed from fscrypt_policy as it does not contain
> any implicit padding and does not refer to an on-disk structure. Even
> though this is a change to a UAPI file, no users will be broken as the
> structure doesn't change.
> 
> Signed-off-by: Joe Richey <joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> ---
>  include/uapi/linux/fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index 048a85e9f017..f6e1c54ac5e2 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -279,7 +279,7 @@ struct fscrypt_policy {
>  	__u8 filenames_encryption_mode;
>  	__u8 flags;
>  	__u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE];
> -} __packed;
> +};

Both patches are fine, just keep my Reviewed-by. :)

Thanks,
//richard

  parent reply	other threads:[~2017-04-07  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 23:14 [PATCH v2] fscrypt: Remove __packed from fscrypt_policy Joe Richey
     [not found] ` <20170406231428.154187-1-joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-07  9:22   ` Richard Weinberger [this message]
2017-04-30  6:16   ` [v2] " Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6e1c40b-ad3d-bf8f-5adc-d0d123e7a28e@nod.at \
    --to=richard-/l3ra7n9ekc@public.gmane.org \
    --cc=jaegeuk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fscrypt-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mhalcrow-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=richard.weinberger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tytso-3s7WtUTddSA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).