From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3DC7C54E4B for ; Thu, 7 May 2020 16:59:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8108E215A4 for ; Thu, 7 May 2020 16:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbgEGQ7A (ORCPT ); Thu, 7 May 2020 12:59:00 -0400 Received: from mga14.intel.com ([192.55.52.115]:26106 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgEGQ7A (ORCPT ); Thu, 7 May 2020 12:59:00 -0400 IronPort-SDR: D/gE71r4FfI1AEosNKpprj+SH70Jt/XTyS8VfucL33gKXCK2CTpOafqcXVZQmLr6e+m/i7R8WR Yo3rPR2FbsLw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 09:58:59 -0700 IronPort-SDR: 4Xav02TGuF5KC6i/HlotdeCsEttQc+IxzROcQP0j4Tq6KHlbIN5CNm7pPTv7WRs0kZz3ZBJG+C TPHvQlt7iSEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,364,1583222400"; d="scan'208";a="305171312" Received: from yyu32-desk.sc.intel.com ([143.183.136.146]) by FMSMGA003.fm.intel.com with ESMTP; 07 May 2020 09:58:59 -0700 Message-ID: Subject: Re: [PATCH v10 05/26] x86/cet/shstk: Add Kconfig option for user-mode Shadow Stack From: Yu-cheng Yu To: Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang Date: Thu, 07 May 2020 09:59:02 -0700 In-Reply-To: References: <20200429220732.31602-1-yu-cheng.yu@intel.com> <20200429220732.31602-6-yu-cheng.yu@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Thu, 2020-05-07 at 08:55 -0700, Dave Hansen wrote: > On 4/29/20 3:07 PM, Yu-cheng Yu wrote: > > +config X86_INTEL_SHADOW_STACK_USER > > + prompt "Intel Shadow Stacks for user-mode" > > + def_bool n > > + depends on CPU_SUP_INTEL && X86_64 > > + depends on AS_HAS_SHADOW_STACK > > + select ARCH_USES_HIGH_VMA_FLAGS > > + select X86_INTEL_CET > > + select ARCH_HAS_SHADOW_STACK > > I called protection keys: X86_INTEL_MEMORY_PROTECTION_KEYS > > AMD recently posted documentation which shows them implementing it as > well. The "INTEL_" is feeling now like a mistake. > > Going forward, we should probably avoid sticking the company name on > them, if for no other reason than avoiding confusion and/or churn in the > future. > > Shadow stacks, for instance, seem like something that another vendor > might implement one day. So, let's at least remove the "INTEL_" from > the config option names themselves. Mentioning Intel in the changelog > and the Kconfig help text is fine. Yes, sure. Yu-cheng