From: Randy Dunlap <rdunlap@infradead.org>
To: Murali Karicheri <m-karicheri2@ti.com>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
nsekhar@ti.com, grygorii.strashko@ti.com,
vinicius.gomes@intel.com
Subject: Re: [net-next v4 PATCH 1/7] hsr: enhance netlink socket interface to support PRP
Date: Mon, 20 Jul 2020 11:37:28 -0700 [thread overview]
Message-ID: <f1675af9-f057-0b7b-c245-e15ead602bbc@infradead.org> (raw)
In-Reply-To: <20200720165803.17793-2-m-karicheri2@ti.com>
On 7/20/20 9:57 AM, Murali Karicheri wrote:
> diff --git a/net/hsr/Kconfig b/net/hsr/Kconfig
> index 8095b034e76e..e2e396870230 100644
> --- a/net/hsr/Kconfig
> +++ b/net/hsr/Kconfig
> @@ -4,24 +4,35 @@
> #
>
> config HSR
> - tristate "High-availability Seamless Redundancy (HSR)"
> - help
> + tristate "High-availability Seamless Redundancy (HSR & PRP)"
> + ---help---
Just use:
help
The use of "---help---" has been discontinued.
> + This enables IEC 62439 defined High-availability Seamless
> + Redundancy (HSR) and Parallel Redundancy Protocol (PRP).
> +
> If you say Y here, then your Linux box will be able to act as a
> - DANH ("Doubly attached node implementing HSR"). For this to work,
> - your Linux box needs (at least) two physical Ethernet interfaces,
> - and it must be connected as a node in a ring network together with
> - other HSR capable nodes.
> + DANH ("Doubly attached node implementing HSR") or DANP ("Doubly
> + attached node implementing PRP"). For this to work, your Linux box
> + needs (at least) two physical Ethernet interfaces.
> +
> + For DANH, it must be connected as a node in a ring network together
> + with other HSR capable nodes. All Ethernet frames sent over the hsr
HSR
> + device will be sent in both directions on the ring (over both slave
> + ports), giving a redundant, instant fail-over network. Each HSR node
> + in the ring acts like a bridge for HSR frames, but filters frames
> + that have been forwarded earlier.
>
> - All Ethernet frames sent over the hsr device will be sent in both
> - directions on the ring (over both slave ports), giving a redundant,
> - instant fail-over network. Each HSR node in the ring acts like a
> - bridge for HSR frames, but filters frames that have been forwarded
> - earlier.
> + For DANP, it must be connected as a node connecting to two
> + separate networks over the two slave interfaces. Like HSR, Ethernet
> + frames sent over the prp device will be sent to both networks giving
PRP
> + a redundant, instant fail-over network. Unlike HSR, PRP networks
> + can have Singly Attached Nodes (SAN) such as PC, printer, bridges
> + etc and will be able to communicate with DANP nodes.
>
> This code is a "best effort" to comply with the HSR standard as
> described in IEC 62439-3:2010 (HSRv0) and IEC 62439-3:2012 (HSRv1),
> - but no compliancy tests have been made. Use iproute2 to select
> - the version you desire.
> + and PRP standard described in IEC 62439-4:2012 (PRP), but no
> + compliancy tests have been made. Use iproute2 to select the protocol
> + you would like to use.
>
> You need to perform any and all necessary tests yourself before
> relying on this code in a safety critical system!
thanks.
--
~Randy
next prev parent reply other threads:[~2020-07-20 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:57 [net-next v4 PATCH 0/7] Add PRP driver Murali Karicheri
2020-07-20 16:57 ` [net-next v4 PATCH 1/7] hsr: enhance netlink socket interface to support PRP Murali Karicheri
2020-07-20 18:37 ` Randy Dunlap [this message]
2020-07-22 13:01 ` Murali Karicheri
2020-07-20 16:57 ` [net-next v4 PATCH 2/7] net: hsr: introduce common code for skb initialization Murali Karicheri
2020-07-20 16:57 ` [net-next v4 PATCH 3/7] net: hsr: introduce protocol specific function pointers Murali Karicheri
2020-07-20 16:58 ` [net-next v4 PATCH 4/7] net: prp: add supervision frame generation utility function Murali Karicheri
2020-07-20 16:58 ` [net-next v4 PATCH 5/7] net: hsr: define and use proto_ops ptrs to handle hsr specific frames Murali Karicheri
2020-07-20 16:58 ` [net-next v4 PATCH 6/7] net: prp: add packet handling support Murali Karicheri
2020-07-20 16:58 ` [net-next v4 PATCH 7/7] net: prp: enhance debugfs to display PRP info Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1675af9-f057-0b7b-c245-e15ead602bbc@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).