From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC4FC43467 for ; Thu, 8 Oct 2020 12:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94DB62083B for ; Thu, 8 Oct 2020 12:50:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729769AbgJHMuO (ORCPT ); Thu, 8 Oct 2020 08:50:14 -0400 Received: from ivanoab7.miniserver.com ([37.128.132.42]:39846 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729722AbgJHMuO (ORCPT ); Thu, 8 Oct 2020 08:50:14 -0400 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQVN4-0006ht-Tj; Thu, 08 Oct 2020 12:50:11 +0000 Received: from jain.kot-begemot.co.uk ([192.168.3.3]) by jain.kot-begemot.co.uk with esmtp (Exim 4.92) (envelope-from ) id 1kQVN2-0000rM-Pa; Thu, 08 Oct 2020 13:50:10 +0100 Subject: Re: [RFC v7 00/21] Unifying LKL into UML To: Hajime Tazaki Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com References: <1ba41b09-6bdb-2fb7-5696-7db429e0a6a5@cambridgegreys.com> From: Anton Ivanov Message-ID: <003d0714-3bb6-dc02-ba3d-0237f8c5f40c@cambridgegreys.com> Date: Thu, 8 Oct 2020 13:50:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Clacks-Overhead: GNU Terry Pratchett Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On 08/10/2020 13:12, Hajime Tazaki wrote: > Hello Anton, > > On Wed, 07 Oct 2020 22:30:03 +0900, > Anton Ivanov wrote: >> >> On 06/10/2020 10:44, Hajime Tazaki wrote: >>> This is another spin of the unification of LKL into UML. Based on the >>> discussion of v4 patchset, we have tried to address issue raised and >>> rewrote the patchset from scratch. The summary is listed in the >>> changelog below. >>> >>> Although there are still bugs in the patchset, we'd like to ask your >>> opinions on the design we changed. >>> >>> The milestone section is also updated: this patchset is for the >>> milestone 1, though the common init API is still not implemented yet. >>> >>> >>> Changes in rfc v7: >>> - preserve `make ARCH=um` syntax to build UML >>> - introduce `make ARCH=um UMMODE=library` to build library mode >>> - fix undefined symbols issue during modpost >>> - clean up makefiles (arch/um, tools/um) >> Hi Hajime, hi Tavi, >> >> Our starting point should be that it does not break the existing build. It still does. > I agree with the starting point. > >> If I build a "stock configuration" UML after applying the patchset >> the resulting vmlinux is not executable. > Ah, I confirmed the issue. > I was only trying to make the `linux` binary compatible, not vmlinux. > > Because vmlinux is now build as a relocatable object, this is > something we need to figure out if we wish to keep vmlinux executable. > > Do you think we should make vmlinux executable even if we have the > file linux executable ? If yes, we will work on this to fix the issue. In my opinion, any relocatable objects, etc should be clearly named - either .o, .so, etc depending on what they are. We should not try to reuse any of the existing files for a different purpose. I also agree with Johannes that we are not using the tools/ directory for its intended purpose. We are not trying to build a tool. We are trying to build a sub-architecture. IMHO, the build should use a subdirectory under arch/um. >> On the positive side, it builds cleanly now. I will try to go >> through the rest of the patchset later today and see if there is >> anything else that needs fixing before we do the next version. > thanks for your time. > > -- Hajime > > -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/