From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Subject: Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests Date: Sat, 27 Jun 2020 10:17:27 +0200 Message-ID: <0ed75013-6ac4-3902-391a-1f7152510c6d@csgroup.eu> References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> Content-Language: fr Sender: linux-doc-owner@vger.kernel.org To: Anshuman Khandual , linux-mm@kvack.org Cc: christophe.leroy@c-s.fr, ziy@nvidia.com, gerald.schaefer@de.ibm.com, Jonathan Corbet , Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley List-Id: linux-arch.vger.kernel.org Le 24/06/2020 à 05:13, Anshuman Khandual a écrit : > > > On 06/15/2020 09:07 AM, Anshuman Khandual wrote: >> This series adds some more arch page table helper validation tests which >> are related to core and advanced memory functions. This also creates a >> documentation, enlisting expected semantics for all page table helpers as >> suggested by Mike Rapoport previously (https://lkml.org/lkml/2020/1/30/40). >> >> There are many TRANSPARENT_HUGEPAGE and ARCH_HAS_TRANSPARENT_HUGEPAGE_PUD >> ifdefs scattered across the test. But consolidating all the fallback stubs >> is not very straight forward because ARCH_HAS_TRANSPARENT_HUGEPAGE_PUD is >> not explicitly dependent on ARCH_HAS_TRANSPARENT_HUGEPAGE. >> >> Tested on arm64, x86 platforms but only build tested on all other enabled >> platforms through ARCH_HAS_DEBUG_VM_PGTABLE i.e powerpc, arc, s390. The >> following failure on arm64 still exists which was mentioned previously. It >> will be fixed with the upcoming THP migration on arm64 enablement series. >> >> WARNING .... mm/debug_vm_pgtable.c:860 debug_vm_pgtable+0x940/0xa54 >> WARN_ON(!pmd_present(pmd_mkinvalid(pmd_mkhuge(pmd)))) >> >> This series is based on v5.8-rc1. >> >> Changes in V3: >> >> - Replaced HAVE_ARCH_SOFT_DIRTY with MEM_SOFT_DIRTY >> - Added HAVE_ARCH_HUGE_VMAP checks in pxx_huge_tests() per Gerald >> - Updated documentation for pmd_thp_tests() per Zi Yan >> - Replaced READ_ONCE() with huge_ptep_get() per Gerald >> - Added pte_mkhuge() and masking with PMD_MASK per Gerald >> - Replaced pte_same() with holding pfn check in pxx_swap_tests() >> - Added documentation for all (#ifdef #else #endif) per Gerald >> - Updated pmd_protnone_tests() per Gerald >> - Updated HugeTLB PTE creation in hugetlb_advanced_tests() per Gerald >> - Replaced [pmd|pud]_mknotpresent() with [pmd|pud]_mkinvalid() >> - Added has_transparent_hugepage() check for PMD and PUD tests >> - Added a patch which debug prints all individual tests being executed >> - Updated documentation for renamed [pmd|pud]_mkinvalid() helpers > > Hello Gerald/Christophe/Vineet, > > It would be really great if you could give this series a quick test > on s390/ppc/arc platforms respectively. Thank you. > Running ok on powerpc 8xx after fixing build failures. Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> From: Christophe Leroy Message-ID: <0ed75013-6ac4-3902-391a-1f7152510c6d@csgroup.eu> Date: Sat, 27 Jun 2020 10:17:27 +0200 MIME-Version: 1.0 In-Reply-To: <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Anshuman Khandual , linux-mm@kvack.org Cc: christophe.leroy@c-s.fr, ziy@nvidia.com, gerald.schaefer@de.ibm.com, Jonathan Corbet , Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: Message-ID: <20200627081727.3l0N0rPvwFOhpl0sJlpuayRH7YWoNqmPFOcF8xIXdV0@z> Le 24/06/2020 =C3=A0 05:13, Anshuman Khandual a =C3=A9crit=C2=A0: >=20 >=20 > On 06/15/2020 09:07 AM, Anshuman Khandual wrote: >> This series adds some more arch page table helper validation tests whi= ch >> are related to core and advanced memory functions. This also creates a >> documentation, enlisting expected semantics for all page table helpers= as >> suggested by Mike Rapoport previously (https://lkml.org/lkml/2020/1/30= /40). >> >> There are many TRANSPARENT_HUGEPAGE and ARCH_HAS_TRANSPARENT_HUGEPAGE_= PUD >> ifdefs scattered across the test. But consolidating all the fallback s= tubs >> is not very straight forward because ARCH_HAS_TRANSPARENT_HUGEPAGE_PUD= is >> not explicitly dependent on ARCH_HAS_TRANSPARENT_HUGEPAGE. >> >> Tested on arm64, x86 platforms but only build tested on all other enab= led >> platforms through ARCH_HAS_DEBUG_VM_PGTABLE i.e powerpc, arc, s390. Th= e >> following failure on arm64 still exists which was mentioned previously= . It >> will be fixed with the upcoming THP migration on arm64 enablement seri= es. >> >> WARNING .... mm/debug_vm_pgtable.c:860 debug_vm_pgtable+0x940/0xa54 >> WARN_ON(!pmd_present(pmd_mkinvalid(pmd_mkhuge(pmd)))) >> >> This series is based on v5.8-rc1. >> >> Changes in V3: >> >> - Replaced HAVE_ARCH_SOFT_DIRTY with MEM_SOFT_DIRTY >> - Added HAVE_ARCH_HUGE_VMAP checks in pxx_huge_tests() per Gerald >> - Updated documentation for pmd_thp_tests() per Zi Yan >> - Replaced READ_ONCE() with huge_ptep_get() per Gerald >> - Added pte_mkhuge() and masking with PMD_MASK per Gerald >> - Replaced pte_same() with holding pfn check in pxx_swap_tests() >> - Added documentation for all (#ifdef #else #endif) per Gerald >> - Updated pmd_protnone_tests() per Gerald >> - Updated HugeTLB PTE creation in hugetlb_advanced_tests() per Gerald >> - Replaced [pmd|pud]_mknotpresent() with [pmd|pud]_mkinvalid() >> - Added has_transparent_hugepage() check for PMD and PUD tests >> - Added a patch which debug prints all individual tests being executed >> - Updated documentation for renamed [pmd|pud]_mkinvalid() helpers >=20 > Hello Gerald/Christophe/Vineet, >=20 > It would be really great if you could give this series a quick test > on s390/ppc/arc platforms respectively. Thank you. >=20 Running ok on powerpc 8xx after fixing build failures. Christophe