Re: [PATCH v2 12/44] metag: TBX source

[Joe Perches <joe@perches.com>]

On Thu, 2012-12-06 at 09:35 +0000, James Hogan wrote:
> On 05/12/12 18:53, Joe Perches wrote:
> > On Wed, 2012-12-05 at 16:08 +0000, James Hogan wrote:
> >> Add source files from the Thread Binary Interface (TBI) library which
> >> provides useful low level operations and traps/context management.
> > []
> >>  arch/metag/tbx/tbicache.c  |  462 ++++++++++++++++++++++++++++++++++++++++++++
> > 
> > Could you please run checkpatch on this file?
> 
> Hi Joe,
> 
> Thanks for taking a look.
> 
> I'd prefer to avoid making style modifications to the tbx/ files if
> possible to ease maintenance, as the code is shared with other projects
> and maintained by a separate group.
> 
> Of course if cleaning up the style is deemed absolutely necessary then
> so be it.

Your choice though the file looks to me to be linux
specific as it uses #include <linux/stddef.h>

Also, two functions, __TBIDataCacheFlush and
__TBICodeCacheFlush, have an unnecessary indentation
level after a test and return.

void __TBICodeCacheFlush( const void *pStart, int Bytes )
{
	volatile int *pCtrl = (volatile int *) SYSC_CACHE_MMU_CONFIG;

	if ( !__TBICacheDoneInit )
		__TBICacheInit();

	if ( (pCtrl[0] & SYSC_CMMUCFG_IC_ON_BIT) == 0 )
	{
		/* No need to flush the code cache it's not actually enabled */
		return;
	} 

	{
		/* Use a sequence of writes to flush the cache region requested */	
		int Loops, Step;

		etc.

I believe the automatics in the second blocks should
be moved to the start of the function and the
unnecessary braces and extra indentation removed.