From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: [PATCH 14/17] sh: get rid of superfluous __GFP_REPEAT Date: Mon, 30 May 2016 11:14:56 +0200 Message-ID: <1464599699-30131-15-git-send-email-mhocko@kernel.org> References: <1464599699-30131-1-git-send-email-mhocko@kernel.org> Return-path: In-Reply-To: <1464599699-30131-1-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Michal Hocko , Yoshinori Sato , Rich Felker , linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org From: Michal Hocko __GFP_REPEAT has a rather weak semantic but since it has been introduced around 2.6.12 it has been ignored for low order allocations. PGALLOC_GFP uses __GFP_REPEAT but {pgd,pmd}_alloc allocate from {pgd,pmd}_cache but both caches are allocating up to PAGE_SIZE objects. This means that this flag has never been actually useful here because it has always been used only for PAGE_ALLOC_COSTLY requests. Cc: Yoshinori Sato Cc: Rich Felker Cc: linux-arch@vger.kernel.org Signed-off-by: Michal Hocko --- arch/sh/mm/pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/mm/pgtable.c b/arch/sh/mm/pgtable.c index 26e03a1f7ca4..a62bd8696779 100644 --- a/arch/sh/mm/pgtable.c +++ b/arch/sh/mm/pgtable.c @@ -1,7 +1,7 @@ #include #include -#define PGALLOC_GFP GFP_KERNEL | __GFP_REPEAT | __GFP_ZERO +#define PGALLOC_GFP GFP_KERNEL | __GFP_ZERO static struct kmem_cache *pgd_cachep; #if PAGETABLE_LEVELS > 2 -- 2.8.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:36437 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932219AbcE3JPY (ORCPT ); Mon, 30 May 2016 05:15:24 -0400 From: Michal Hocko Subject: [PATCH 14/17] sh: get rid of superfluous __GFP_REPEAT Date: Mon, 30 May 2016 11:14:56 +0200 Message-ID: <1464599699-30131-15-git-send-email-mhocko@kernel.org> In-Reply-To: <1464599699-30131-1-git-send-email-mhocko@kernel.org> References: <1464599699-30131-1-git-send-email-mhocko@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Michal Hocko , Yoshinori Sato , Rich Felker , linux-arch@vger.kernel.org Message-ID: <20160530091456.R-LSp6WbshmqF3zt657nnfduqxSv_YOmrvtvlMVSKY0@z> From: Michal Hocko __GFP_REPEAT has a rather weak semantic but since it has been introduced around 2.6.12 it has been ignored for low order allocations. PGALLOC_GFP uses __GFP_REPEAT but {pgd,pmd}_alloc allocate from {pgd,pmd}_cache but both caches are allocating up to PAGE_SIZE objects. This means that this flag has never been actually useful here because it has always been used only for PAGE_ALLOC_COSTLY requests. Cc: Yoshinori Sato Cc: Rich Felker Cc: linux-arch@vger.kernel.org Signed-off-by: Michal Hocko --- arch/sh/mm/pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/mm/pgtable.c b/arch/sh/mm/pgtable.c index 26e03a1f7ca4..a62bd8696779 100644 --- a/arch/sh/mm/pgtable.c +++ b/arch/sh/mm/pgtable.c @@ -1,7 +1,7 @@ #include #include -#define PGALLOC_GFP GFP_KERNEL | __GFP_REPEAT | __GFP_ZERO +#define PGALLOC_GFP GFP_KERNEL | __GFP_ZERO static struct kmem_cache *pgd_cachep; #if PAGETABLE_LEVELS > 2 -- 2.8.1