From: Jessica <jeyu@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>
Cc: Eddie Kovsky <ewk@edkovsky.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Jessica Yu <jeyu@redhat.com>
Subject: [PATCH] vmlinux.lds: add missing VMLINUX_SYMBOL macros
Date: Mon, 3 Apr 2017 15:43:07 -0700
Message-ID: <1491259387-15869-1-git-send-email-jeyu@redhat.com> (raw)
From: Jessica Yu <jeyu@redhat.com>
When __{start,end}_ro_after_init is referenced from C code, we run into the
following build errors on blackfin:
kernel/extable.c:169: undefined reference to `__start_ro_after_init'
kernel/extable.c:169: undefined reference to `__end_ro_after_init'
The build error is due to the fact that blackfin is one of the few arches
that prepends an underscore '_' to all symbols defined in C. Fix this by
wrapping __{start,end}_ro_after_init in vmlinux.lds.h with VMLINUX_SYMBOL(),
which adds the necessary prefix for arches that have HAVE_UNDERSCORE_SYMBOL_PREFIX.
Signed-off-by: Jessica Yu <jeyu@redhat.com>
---
This patch is based on next-20170403.
include/asm-generic/vmlinux.lds.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 979b573..54918ae 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -261,9 +261,9 @@
*/
#ifndef RO_AFTER_INIT_DATA
#define RO_AFTER_INIT_DATA \
- __start_ro_after_init = .; \
+ VMLINUX_SYMBOL(__start_ro_after_init) = .; \
*(.data..ro_after_init) \
- __end_ro_after_init = .;
+ VMLINUX_SYMBOL(__end_ro_after_init) = .;
#endif
/*
--
2.5.5
next reply index
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 22:43 Jessica [this message]
2017-04-03 23:30 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491259387-15869-1-git-send-email-jeyu@redhat.com \
--to=jeyu@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ewk@edkovsky.org \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-arch Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-arch/0 linux-arch/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-arch linux-arch/ https://lore.kernel.org/linux-arch \
linux-arch@vger.kernel.org
public-inbox-index linux-arch
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arch
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git