From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salyzyn Subject: Re: [PATCH v2 24/28] arm: Add support for generic vDSO Date: Mon, 10 Dec 2018 14:13:43 -0800 Message-ID: <1f5de1a7-04f0-152f-03ad-e581b0ec1b17@android.com> References: <20181129170530.37789-1-vincenzo.frascino@arm.com> <20181129170530.37789-25-vincenzo.frascino@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181129170530.37789-25-vincenzo.frascino@arm.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vincenzo Frascino , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Arnd Bergmann , Catalin Marinas , Daniel Lezcano , Will Deacon , Russell King , Ralf Baechle , Paul Burton , Thomas Gleixner , Peter Collingbourne List-Id: linux-arch.vger.kernel.org T24gMTEvMjkvMjAxOCAwOTowNSBBTSwgVmluY2Vuem8gRnJhc2Npbm8gd3JvdGU6Cj4gVGhlIGFy bSB2RFNPIGxpYnJhcnkgcmVxdWlyZXMgc29tZSBhZGFwdGF0aW9ucyB0byB1c2UgdG8gdGFrZSBh ZHZhbnRhZ2UKPiBvZiB0aGUgbmV3bHkgaW50cm9kdWNlZCBnZW5lcmljIHZEU08gbGlicmFyeS4K VGVzdGVkLWJ5PyBXb3VsZCBsaWtlIHRvIG5vdGUgdGhhdCB0aGlzIHBhdGNoIHNlcmllcyB1cCB0 byAyNC8yOCB3YXMgCmJhY2stcG9ydGVkIHRvIGFuZHJvaWQtNC45IGFuZCB3b3JrZWQgc3VjY2Vz c2Z1bGx5IG9uIGEgSGlrZXkgYXJtNjQgZGV2aWNlLgoKT25seSBzaWduaWZpY2FudCBjaGFuZ2Ug d2FzIHRvIGFkZCBiYWNrIHN1cHBvcnQgZm9yIGNsYW5nIGluIAphcmNoL2FybTY0L01ha2VmaWxl IChwc2V1ZG8gcGF0Y2gpOgoKIMKgaWZlcSAoJChDT05GSUdfR0VORVJJQ19DT01QQVRfVkRTTyks IHkpCiDCoMKgIENST1NTX0NPTVBJTEVfQVJNMzIgPz0gJChDT05GSUdfQ1JPU1NfQ09NUElMRV9D T01QQVRfVkRTTzoiJSI9JSkKCiDCoMKgIGlmZXEgKCQoQ1JPU1NfQ09NUElMRV9BUk0zMiksKQog wqDCoCDCoCAkKGVycm9yIENST1NTX0NPTVBJTEVfQVJNMzIgbm90IGRlZmluZWQgb3IgZW1wdHks IHRoZSBjb21wYXQgdkRTTyAKd2lsbCBub3QgYmUgYnVpbHQpCivCoMKgIGVsc2UgaWZlcSAoJChj Yy1uYW1lKSxjbGFuZykKK8KgwqAgwqAgZXhwb3J0IENMQU5HX1RSSVBMRV9BUk0zMiA/PSAkKENS T1NTX0NPTVBJTEVfQVJNMzIpCivCoMKgwqDCoCBleHBvcnQgQ0xBTkdfVEFSR0VUX0FSTTMyIDo9 IC0tdGFyZ2V0PSQobm90ZGlyIAokKENMQU5HX1RSSVBMRV9BUk0zMjolLT0lKSkKK8KgwqDCoMKg IGV4cG9ydCBDT05GSUdfQ09NUEFUX1ZEU08gOj0geQorwqDCoMKgwqAgY29tcGF0X3Zkc28gOj0g LURDT05GSUdfQ09NUEFUX1ZEU089MQotKyDCoCBlbHNlIGlmZXEgKCQoc2hlbGwgd2hpY2ggJChD Uk9TU19DT01QSUxFX0FSTTMyKSQoY2MtbmFtZSkgMj4gCi9kZXYvbnVsbCksKQotKyDCoCDCoCAk KGVycm9yICQoQ1JPU1NfQ09NUElMRV9BUk0zMikkKGNjLW5hbWUpIG5vdCBmb3VuZCwgY2hlY2sg CkNST1NTX0NPTVBJTEVfQVJNMzIpCiDCoMKgIGVsc2UKIMKgwqAgwqAgZXhwb3J0IENST1NTX0NP TVBJTEVfQVJNMzIKIMKgwqDCoMKgIGV4cG9ydCBDT05GSUdfQ09NUEFUX1ZEU08gOj0geQogwqDC oMKgwqAgY29tcGF0X3Zkc28gOj0gLURDT05GSUdfQ09NUEFUX1ZEU089MQogwqDCoCBlbmRpZgog wqBlbmRpZgoKLS0gTWFyawoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f194.google.com ([209.85.210.194]:39976 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727146AbeLJWNr (ORCPT ); Mon, 10 Dec 2018 17:13:47 -0500 Received: by mail-pf1-f194.google.com with SMTP id i12so6056041pfo.7 for ; Mon, 10 Dec 2018 14:13:46 -0800 (PST) Subject: Re: [PATCH v2 24/28] arm: Add support for generic vDSO References: <20181129170530.37789-1-vincenzo.frascino@arm.com> <20181129170530.37789-25-vincenzo.frascino@arm.com> From: Mark Salyzyn Message-ID: <1f5de1a7-04f0-152f-03ad-e581b0ec1b17@android.com> Date: Mon, 10 Dec 2018 14:13:43 -0800 MIME-Version: 1.0 In-Reply-To: <20181129170530.37789-25-vincenzo.frascino@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Sender: linux-arch-owner@vger.kernel.org List-ID: To: Vincenzo Frascino , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Peter Collingbourne Message-ID: <20181210221343.eVhtggVTl8jTuYIduHlYod-1BoAUzoPM3U0SH7yIBl8@z> On 11/29/2018 09:05 AM, Vincenzo Frascino wrote: > The arm vDSO library requires some adaptations to use to take advantage > of the newly introduced generic vDSO library. Tested-by? Would like to note that this patch series up to 24/28 was back-ported to android-4.9 and worked successfully on a Hikey arm64 device. Only significant change was to add back support for clang in arch/arm64/Makefile (pseudo patch):  ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y)    CROSS_COMPILE_ARM32 ?= $(CONFIG_CROSS_COMPILE_COMPAT_VDSO:"%"=%)    ifeq ($(CROSS_COMPILE_ARM32),)      $(error CROSS_COMPILE_ARM32 not defined or empty, the compat vDSO will not be built) +   else ifeq ($(cc-name),clang) +     export CLANG_TRIPLE_ARM32 ?= $(CROSS_COMPILE_ARM32) +     export CLANG_TARGET_ARM32 := --target=$(notdir $(CLANG_TRIPLE_ARM32:%-=%)) +     export CONFIG_COMPAT_VDSO := y +     compat_vdso := -DCONFIG_COMPAT_VDSO=1 -+   else ifeq ($(shell which $(CROSS_COMPILE_ARM32)$(cc-name) 2> /dev/null),) -+     $(error $(CROSS_COMPILE_ARM32)$(cc-name) not found, check CROSS_COMPILE_ARM32)    else      export CROSS_COMPILE_ARM32      export CONFIG_COMPAT_VDSO := y      compat_vdso := -DCONFIG_COMPAT_VDSO=1    endif  endif -- Mark