Re: [PATCH v2] Add preadv and pwritev system calls.

From: Gerd Hoffmann <kraxel@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	Scott Lurndal <scott.lurndal@3leafsystems.com>,
	Matthew Wilcox <matthew@wil.cx>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Ulrich Drepper <drepper@redhat.com>
Subject: Re: [PATCH v2] Add preadv and pwritev system calls.
Date: Fri, 12 Dec 2008 21:39:18 +0100	[thread overview]
Message-ID: <4942CBF6.5090105@redhat.com> (raw)
Message-ID: <20081212203918.RSRYOZNb2YvndkxqhX10inRQLkRegJWXnLi9cxmMlUc@z> (raw)
In-Reply-To: <20081212201239.GE5774@flint.arm.linux.org.uk>

Russell King wrote:
> On Fri, Dec 12, 2008 at 08:56:00PM +0100, Gerd Hoffmann wrote:
>> Russell King wrote:
>>>> should be similar to pread/pwrite, e.g:
>>>>
>>>>     int preadv(fd, iovec, iovec_size, offset)
>>> Yes, and that's easy for glibc to achieve.
>> This hints the ABI problem exists at syscall level only.  Is that
>> correct?  So we can have
>>
>> 	preadv(fd, vec, vlen, off)
>>
>> argument ordering at app <-> glibc level and
>>
>> 	preadv(fd, vec, off, vlen)
>>
>> ordering at glibc <-> kernel (aka syscall) level and it works fine for
>> ARM + MIPS + PARISC?
> 
> Fine for ARM

Great.  I'll happily switch the ordering then.  /me goes wait for acks
from the other archs and plans for a new patch revision early next week.

thanks,
  Gerd