From: David Miller <davem@davemloft.net>
To: paulus@samba.org
Cc: matthew@wil.cx, kraxel@redhat.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH v2] Add preadv and pwritev system calls.
Date: Sun, 14 Dec 2008 22:20:43 -0800 (PST) [thread overview]
Message-ID: <20081214.222043.249008274.davem@davemloft.net> (raw)
In-Reply-To: <18757.55706.609537.196994@drongo.ozlabs.ibm.com>
From: Paul Mackerras <paulus@samba.org>
Date: Mon, 15 Dec 2008 15:14:18 +1100
> Matthew Wilcox writes:
>
> > On Fri, Dec 12, 2008 at 03:00:40PM +0100, Gerd Hoffmann wrote:
> > > The patch sports the actual system call implementation and the windup in
> > > the x86 system call tables. Other archs are TBD.
> >
> > > +asmlinkage ssize_t sys_preadv(unsigned long fd, const struct iovec __user *vec,
> > > + unsigned long vlen, loff_t pos)
> > > +asmlinkage ssize_t sys_pwritev(unsigned long fd, const struct iovec __user *vec,
> > > + unsigned long vlen, loff_t pos)
> >
> > Are these prototypes required? MIPS and PARISC will need wrappers to
> > fix them if they are. These two architectures have an ABI which
> > requires 64-bit arguments to be passed in aligned pairs of registers,
>
> As does 32-bit PowerPC, so I also would prefer the alternate argument
> order for the syscall (pos as the 3rd argument).
FWIW 32-bit sparc does not have the aligned register requirement
for 64-bit arguments.
next prev parent reply other threads:[~2008-12-15 6:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 14:00 [PATCH v2] Add preadv and pwritev system calls Gerd Hoffmann
2008-12-12 15:29 ` Matthew Wilcox
2008-12-12 15:48 ` Gerd Hoffmann
2008-12-12 15:51 ` Matthew Wilcox
2008-12-12 16:02 ` Gerd Hoffmann
2008-12-12 17:03 ` Matthew Wilcox
2008-12-12 17:03 ` Matthew Wilcox
2008-12-12 18:21 ` Alan Cox
2008-12-12 19:02 ` Russell King
2008-12-12 18:29 ` Scott Lurndal
2008-12-12 19:07 ` Russell King
2008-12-12 19:56 ` Gerd Hoffmann
2008-12-12 19:56 ` Gerd Hoffmann
2008-12-12 20:12 ` Russell King
2008-12-12 20:12 ` Russell King
2008-12-12 20:39 ` Gerd Hoffmann
2008-12-12 20:39 ` Gerd Hoffmann
2008-12-14 18:19 ` Pavel Machek
2008-12-14 18:19 ` Pavel Machek
2008-12-15 16:37 ` Jennifer Pioch
2008-12-15 20:43 ` Gerd Hoffmann
2008-12-16 9:57 ` Arnd Bergmann
[not found] ` <200812161057.03025.arnd-r2nGTMty4D4@public.gmane.org>
2008-12-17 1:45 ` Dan Mick
2008-12-17 1:45 ` [osol-code] " Dan Mick
2008-12-12 19:47 ` Arnd Bergmann
2008-12-12 20:02 ` Gerd Hoffmann
2008-12-14 11:49 ` Heiko Carstens
2008-12-15 4:14 ` Paul Mackerras
2008-12-15 6:20 ` David Miller [this message]
2008-12-12 15:40 ` Ralf Baechle
2008-12-12 16:59 ` Russell King
2008-12-13 1:18 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081214.222043.249008274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kraxel@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).