From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f171.google.com ([209.85.217.171]:34405 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967209AbcAZRsu (ORCPT ); Tue, 26 Jan 2016 12:48:50 -0500 Received: by mail-lb0-f171.google.com with SMTP id cl12so96332606lbc.1 for ; Tue, 26 Jan 2016 09:48:49 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20160126174441.GA18873@ravnborg.org> References: <20160126062951.GA17107@ravnborg.org> <20160125.225100.1932707129794761764.davem@davemloft.net> <20160126174441.GA18873@ravnborg.org> From: Andy Lutomirski Date: Tue, 26 Jan 2016 09:48:29 -0800 Message-ID: Subject: Re: [PATCH v2 02/16] sparc/compat: Provide an accurate in_compat_syscall implementation Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Sam Ravnborg Cc: David Miller , Andrew Lutomirski , Andrew Morton , Al Viro , Linus Torvalds , X86 ML , linux-arch , "linux-s390@vger.kernel.org" , Chris Metcalf , linux-parisc@vger.kernel.org, Linux MIPS Mailing List , sparclinux@vger.kernel.org Message-ID: <20160126174829.CQ5cyX_SyTlvnT5lV5mfm82KnrFzT_G5tn5lgy-jP24@z> On Tue, Jan 26, 2016 at 9:44 AM, Sam Ravnborg wrote: > On Mon, Jan 25, 2016 at 10:51:00PM -0800, David Miller wrote: >> From: Sam Ravnborg >> Date: Tue, 26 Jan 2016 07:29:51 +0100 >> >> > Could you please add a comment about where 0x110 comes from. >> > I at least failed to track this down. >> >> Frankly I'm fine with this. Someone who understands sparc64 can look >> at the trap table around entry 0x110 and see: >> >> tl0_resv10e: BTRAP(0x10e) BTRAP(0x10f) >> tl0_linux32: LINUX_32BIT_SYSCALL_TRAP >> tl0_oldlinux64: LINUX_64BIT_SYSCALL_TRAP > > If one realise to look in the trap table in the first place - yes. > > Adding a short: > > /* Check if this is LINUX_32BIT_SYSCALL_TRAP */ > Would make wonders to readability. I'll add a comment in v2. --Andy -- Andy Lutomirski AMA Capital Management, LLC